Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "fix: keyboard is not displayed on iOS for autofocused inputs" #59287

Merged
merged 1 commit into from
Mar 28, 2025
Merged

[CP Staging] Revert "fix: keyboard is not displayed on iOS for autofocused inputs" #59287

merged 1 commit into from
Mar 28, 2025

Conversation

cristipaval
Copy link
Contributor

@cristipaval cristipaval commented Mar 28, 2025 •
edited
Loading

Reverts #58760

Fixes
$ #59234
$ #59234
$ #59240
$ #59244

@cristipaval cristipaval self-assigned this Mar 28, 2025
@cristipaval cristipaval requested a review from a team as a code owner March 28, 2025 10:26
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 28, 2025

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot bot requested review from mollfpr and removed request for a team March 28, 2025 10:26
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 28, 2025

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mollfpr mollfpr merged commit e47516d into main Mar 28, 2025
13 of 16 checks passed
@mollfpr mollfpr deleted the revert-58760-fix/keyboard-not-shown-on-ios branch March 28, 2025 10:27
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 28, 2025

@mollfpr looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Mar 28, 2025
@mollfpr mollfpr removed the Emergency label Mar 28, 2025
@mollfpr
Copy link
Contributor

mollfpr commented Mar 28, 2025

Straight revert and needed to clear deploy blocker.

@cristipaval cristipaval changed the title Revert "fix: keyboard is not displayed on iOS for autofocused inputs" [CP Staging] Revert "fix: keyboard is not displayed on iOS for autofocused inputs" Mar 28, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Mar 28, 2025
@mollfpr @OSBotify
Merge pull request #59287 from Expensify/revert-58760-fix/keyboard-no…
edfa0a9 
…t-shown-on-ios

Revert "fix: keyboard is not displayed on iOS for autofocused inputs"

(cherry picked from commit e47516d)

(CP triggered by cristipaval)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Mar 28, 2025
@github-actions github-actions bot mentioned this pull request Mar 28, 2025
Closed
45 tasks
@cristipaval cristipaval mentioned this pull request Mar 28, 2025
Closed
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.1.20-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@dangrous
Copy link
Contributor

dangrous commented Mar 28, 2025 •
edited
Loading

hi! Would this have caused #59299 ? Seems like it might be related...

EDIT: never mind, I think it was https://github.com/Expensify/Mobile-Expensify/pull/13494

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.20-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollfpr mollfpr mollfpr approved these changes

Assignees

@cristipaval cristipaval

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristipaval @mollfpr @OSBotify @dangrous