Unify invoice report title in chats preview in Reports #59292

rezkiy37 · 2025-03-28T11:42:21Z

Explanation of Change

The PR manages a case with OD and ND invoice titles in Reports. It should render the Invoice AAAA-MM-DD pattern for OD ones but the "owes" pattern for ND ones.

Fixed Issues

$ #58581
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Go to FAB > Send invoice.
Send an invoice to any user.
In invoice room, go to invoice report.
Send a message in the invoice report.
Go to Report.
Go to Chats.
Verify the invoice report title in the message preview matches the actual invoice report title.

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as tests.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…o use it

…eter and simplify report retrieval

melvin-bot · 2025-03-28T11:59:19Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…/58581-invoice-report-title

rezkiy37 · 2025-03-31T10:36:03Z

I've synced it up and fixed conflicts.

shubham1206agra · 2025-03-31T15:02:38Z

src/libs/ReportUtils.ts

@@ -9472,6 +9476,16 @@ function isTestTransactionReport(report: OnyxEntry<Report>): boolean {
    return isSelectedManagerMcTest(persionalDetails?.login);
 }

+function getChatListItemReportName(action: ReportAction & {reportID: string; reportName?: string}): string {
+    const report = getReport(action.reportID, allReports);


@rezkiy37 Please use report from search results only. Otherwise, it might give issues.

I got your concert. I've fixed it here: 872eb38.

Screenshot

- Updated Search component to pass queryJSONHash to SearchList. - Modified SearchList to accept queryJSONHash and use it in rendering. - Enhanced ChatListItem to utilize queryJSONHash for fetching current search results. - Updated types to include queryJSONHash in ChatListItemProps.

…/58581-invoice-report-title

rezkiy37 · 2025-04-01T12:22:34Z

I've synced it up and fixed conflicts.

…/58581-invoice-report-title

rezkiy37 · 2025-04-02T08:39:00Z

I've synced it up and fixed conflicts.

cc @shubham1206agra

rezkiy37 · 2025-04-03T09:01:41Z

@shubham1206agra just a friendly reminder.

shubham1206agra · 2025-04-03T11:00:16Z

@rezkiy37 I will do the review today

shubham1206agra · 2025-04-03T15:32:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-04-03T15:33:22Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #58581 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2025-04-03T15:56:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-03T17:10:33Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.23-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rezkiy37 added 4 commits March 28, 2025 11:59

integrate getInvoiceReportName

c2eece5

integrate isInvoiceReportByReportID

5910890

Implement getChatListItemReportName utility and update ChatListItem t…

c9192f7

…o use it

Refactor getChatListItemReportName function to require reportID param…

184b8a4

…eter and simplify report retrieval

rezkiy37 changed the title ~~[WIP] Unify invoice report title in chats preview in Reports~~ Unify invoice report title in chats preview in Reports Mar 28, 2025

rezkiy37 marked this pull request as ready for review March 28, 2025 11:59

rezkiy37 requested a review from a team as a code owner March 28, 2025 11:59

melvin-bot bot requested review from shubham1206agra and removed request for a team March 28, 2025 11:59

rezkiy37 mentioned this pull request Mar 28, 2025

[$250] Reports - Invoice report title in message preview does not match the actual report title #58581

Open

8 tasks

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

5f0bd94

…/58581-invoice-report-title

shubham1206agra reviewed Mar 31, 2025

View reviewed changes

rezkiy37 added 2 commits April 1, 2025 14:19

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

d8531e2

…/58581-invoice-report-title

rezkiy37 requested a review from shubham1206agra April 1, 2025 12:22

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

3145274

…/58581-invoice-report-title

shubham1206agra approved these changes Apr 3, 2025

View reviewed changes

melvin-bot bot requested a review from Julesssss April 3, 2025 15:33

shubham1206agra approved these changes Apr 3, 2025

View reviewed changes

Julesssss approved these changes Apr 3, 2025

View reviewed changes

Julesssss merged commit 51880b1 into Expensify:main Apr 3, 2025
18 checks passed

github-actions bot mentioned this pull request Apr 3, 2025

Deploy Checklist: New Expensify 2025-04-03 #59590

Open

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unify invoice report title in chats preview in Reports #59292

Unify invoice report title in chats preview in Reports #59292

rezkiy37 commented Mar 28, 2025 •

edited

Loading

melvin-bot bot commented Mar 28, 2025

rezkiy37 commented Mar 31, 2025

shubham1206agra Mar 31, 2025

rezkiy37 Apr 1, 2025

rezkiy37 commented Apr 1, 2025

rezkiy37 commented Apr 2, 2025

rezkiy37 commented Apr 3, 2025

shubham1206agra commented Apr 3, 2025

shubham1206agra commented Apr 3, 2025

melvin-bot bot commented Apr 3, 2025

OSBotify commented Apr 3, 2025

github-actions bot commented Apr 3, 2025

Unify invoice report title in chats preview in Reports #59292

Unify invoice report title in chats preview in Reports #59292

Conversation

rezkiy37 commented Mar 28, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 28, 2025

rezkiy37 commented Mar 31, 2025

shubham1206agra Mar 31, 2025

Choose a reason for hiding this comment

rezkiy37 Apr 1, 2025

Choose a reason for hiding this comment

rezkiy37 commented Apr 1, 2025

rezkiy37 commented Apr 2, 2025

rezkiy37 commented Apr 3, 2025

shubham1206agra commented Apr 3, 2025

shubham1206agra commented Apr 3, 2025

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Apr 3, 2025

OSBotify commented Apr 3, 2025

github-actions bot commented Apr 3, 2025

rezkiy37 commented Mar 28, 2025 •

edited

Loading