Skip to content

Add Greek (el) as beta locale#95655

Draft
roryabraham wants to merge 8 commits into
mainfrom
rory-657039-greek-locale
Draft

Add Greek (el) as beta locale#95655
roryabraham wants to merge 8 commits into
mainfrom
rory-657039-greek-locale

Conversation

@roryabraham

@roryabraham roryabraham commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds Greek (el) as a new beta locale. Registers el in LOCALES.ts, wires runtime loading in IntlStore (translations + date-fns locale), maps Apple Sign In's el_GR locale, loads Greek Intl.ListFormat polyfill data, adds a Greek translation prompt/glossary, and generates src/languages/el.ts from en.ts (6,048 strings, zero translation failures). Excludes the generated file from ESLint and cspell, matching every other beta locale's pattern.

This lands the infra prerequisite for Add Greek as a language to E/App, part of the translator-hiring epic #504749. Greek ships as beta: AI-generated, unaudited, no localized emoji keywords — same limitations as de/fr/ja/etc. Promoting to fully-supported happens after expert audit in a follow-up.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/657039
PROPOSAL:

Tests

  1. Start the web dev server.
  2. Sign in and go to Settings > Preferences > Language.
  3. Confirm Ελληνικά appears in the language list.
  4. Select Ελληνικά. Confirm the UI switches to Greek and the "translations generated automatically" hint shows under the Language row.
  5. Navigate to Home, Inbox, and other Account tabs. Confirm nav labels and settings render in Greek with no raw English fallback, no undefined/[object Object], and no missing-key errors.
  6. Switch back to English. Confirm the list re-sorts correctly and English strings are unaffected.
  • Verify that no errors appear in the JS console

Offline tests

N/A — locale files are bundled at build time; no network-dependent behavior changes.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — web-only locale infra change, no native platform code touched.

Android: mWeb Chrome

N/A — see MacOS: Chrome / Safari for representative web coverage.

iOS: Native

N/A — web-only locale infra change, no native platform code touched.

iOS: mWeb Safari

N/A — see MacOS: Chrome / Safari for representative web coverage.

MacOS: Chrome / Safari image image image image

roryabraham and others added 7 commits July 8, 2026 18:17
@roryabraham @cursoragent
feat(i18n): register Greek locale
7158ae9 
Add el to BETA_LOCALES with Ελληνικά display name.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
feat(i18n): wire Greek runtime loaders
4a7b373 
Add el loader to IntlStore (date-fns/locale/el), map el to Apple
Sign In's el_GR locale, and load el Intl.ListFormat polyfill data.

Note: src/languages/el.ts does not exist yet; typecheck passes once
added in a follow-up commit.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
feat(i18n): add Greek translation prompt
dd01538 
Add glossary and tone rules for Greek to guide translation
generation (formal register, gender/case agreement).

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
feat(i18n): generate Greek translations
07e6750 
Generate src/languages/el.ts from en.ts via generateTranslations.ts,
using the base and Greek-specific prompts. 6,048 strings translated
with zero failures.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
chore(lint): exclude generated el.ts from ESLint
27aa359 
Match the existing pattern for other AI-generated locale files;
still type-checked, just not linted as hand-authored source.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
chore(spell): exclude generated el files from cspell
75992d1 
Match the existing ignorePaths pattern for other beta locales;
without this, CI spell-check fails on ~10k lines of Greek text.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
chore(spell): add Greek native name to cspell words
ec97470 
Ελληνικά in LOCALES.ts's LOCALE_TO_LANGUAGE_STRING is hand-written
(not covered by ignorePaths), so it needs a words entry like the
other locales' native display names (Deutsch, Français, etc.).

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham

roryabraham commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

CI failed on two unrelated, pre-existing test failures (both look like date/time-bomb bugs, not caused by this PR's Greek locale changes):

  • test (job 3): tests/unit/ReportSecondaryActionUtilsTest.ts › getSecondaryAction › should include SUBMIT option for admin with only pending transactions — expected true, got false. Run
  • test (job 8): tests/actions/ReportPreviewActionUtilsTest.ts › getReportPreviewAction › canSubmit should return true for expense preview report with only pending transactions — expected "submit", got "view". Run

Both tests use a hardcoded transaction created: '2025-01-01' and appear to depend on the gap between that fixed date and the real current date. Confirmed unrelated to this PR:

  • Reproduces locally on this branch with today's real system date (npx jest tests/unit/ReportSecondaryActionUtilsTest.ts -t "should include SUBMIT option for admin with only pending transactions").
  • main's own last test.yml run (2026-07-01) was green; the regression appeared sometime after that, before this PR's diff (which only touches src/CONST/LOCALES.ts, src/languages/IntlStore.ts, AppleSignInLocales.ts, polyfillListFormat.ts, translation prompts, and the generated el.ts — nothing in ReportSecondaryActionUtils/ReportPreviewActionUtils).

Tracked in Fix flaky test ReportSecondaryActionUtilsTest/ReportPreviewActionUtilsTest.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95655.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1b875f05848-af7837c-0bcbdefb8be20baf0ecf6048cd7a7ee9de0f28ad/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1b875f0-af7837c-088b7f64fc54efc914a619ca03252a95333703c0/index.html
Android iOS
Web 🕸️
https://95655.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@roryabraham