Skip to content

Fix emoji reaction removal crash after hex-key migration#95664

Draft
roryabraham wants to merge 5 commits into
mainfrom
rory-emoji-hex-finally-fix
Draft

Fix emoji reaction removal crash after hex-key migration#95664
roryabraham wants to merge 5 commits into
mainfrom
rory-emoji-hex-finally-fix

Conversation

@roryabraham

@roryabraham roryabraham commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Auth#22634 migrates emoji reactions to be stored under canonical hex-codes (e.g. 1F604) and NIL-merges the legacy name-keyed entry (e.g. smile) in its Onyx response. App still writes its optimistic/finally Onyx updates under the name key, so addEmojiReaction's finallyData was re-creating a name-keyed stub ({pendingAction: null}, with no users) right after the server had already cleared it. toggleEmojiReaction then crashed with TypeError: Cannot read properties of undefined (reading '<accountID>') when it tried to read .users off that stub while deciding whether to add or remove a reaction.

This PR is an App-only fix:

  1. addEmojiReaction's finallyData now NILs the optimistic name key and clears pendingAction on the canonical hex key instead, so it doesn't undo the server's Onyx merge.
  2. toggleEmojiReaction and hasAccountIDEmojiReacted now guard against a reaction entry that is missing users, so any lingering partial entry is treated as "no reaction" rather than throwing.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/504276
PROPOSAL:

Companion backend change: Auth#22634

Tests

  1. Deploy the Auth#22634 branch locally so emoji reactions are stored under hex keys.
  2. Open a report and add an emoji reaction to a message.
  3. Click the reaction bubble again to remove it.
  4. Verify the reaction is removed and no TypeError appears in the JS console.
  5. Repeat steps 2-4 a few times in a row to confirm toggling on/off doesn't corrupt Onyx state.
  6. Run npm run test -- EmojiReactionsTest and confirm all tests pass.
  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off network connectivity.
  2. Add an emoji reaction, then remove it.
  3. Verify no crash occurs and the optimistic UI updates as expected while offline.
  4. Restore connectivity and verify the reaction state reconciles correctly once the request completes.

QA Steps

  1. Open a report and add an emoji reaction to a message.
  2. Click the reaction bubble again to remove it.
  3. Verify the reaction disappears and no error is shown.
  4. Repeat adding/removing the same reaction a few times to confirm there's no crash.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

roryabraham and others added 5 commits July 9, 2026 00:47
@roryabraham @cursoragent
test: reproduce emoji remove crash with name-key stub
908520d 
Adds a regression test that reproduces the TypeError thrown by
toggleEmojiReaction when a legacy name-keyed reaction stub (left
behind without a `users` field) coexists with a hex-keyed reaction,
which is the Onyx shape produced once Auth writes emoji reactions
under hex keys.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
fix: guard emoji reaction toggle against missing users
4ba43e9 
toggleEmojiReaction crashed when a reaction entry existed without a
`users` field (e.g. a legacy name-keyed stub left behind after Auth
NILs it post hex-key migration). Guard both the call sites and
hasAccountIDEmojiReacted itself so a partial reaction entry is
treated as "no reaction" instead of throwing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
test: assert addEmojiReaction finallyData clears name stub
fc77559 
Asserts that addEmojiReaction's finallyData NILs the optimistic
name-keyed entry and clears pendingAction on the canonical hex key,
instead of recreating a name-key stub after the server has already
merged the hex-keyed reaction into Onyx.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
fix: NIL name key in addEmojiReaction finallyData after hex
5242f0e 
Auth now stores emoji reactions under canonical hexcodes and clears
legacy name-keyed entries in its Onyx response. addEmojiReaction's
finallyData still cleared pendingAction on the name key only, which
recreated a name-key stub (with no `users`) right after the server
had already NILed it, corrupting Onyx and crashing removal. Now the
name key is NILed and pendingAction is cleared on the hex key
instead, matching Auth's post-response Onyx shape.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham @cursoragent
test: satisfy lint/type checks in emoji reaction fixtures
a1cabc0 
Reworks the two new regression tests to stay within eslint-seatbelt's
budget for unsafe type assertions and to satisfy the strict
ReportActionReaction type: builds the name-key stub with a fully
typed object and removes its `users` field via Reflect.deleteProperty
instead of an untyped literal, and asserts on write() calls with
toHaveBeenCalledWith/objectContaining instead of casting the mock's
call arguments.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@roryabraham