Skip to content

[HOLD App#96205][No QA] Add npm min-release-age cooldown for supply chain protection#95897

Draft
NicolasBonet wants to merge 4 commits into
mainfrom
claude-npm-min-release-age
Draft

[HOLD App#96205][No QA] Add npm min-release-age cooldown for supply chain protection#95897
NicolasBonet wants to merge 4 commits into
mainfrom
claude-npm-min-release-age

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14014

HOLD on #96205min-release-age requires npm 11 (11.10+ for the setting, 11.17+ for the exclude list). That PR upgrades Node to 26.5.0, which bundles npm 11.17.0, so no separate npm bump is needed. Until it merges, npm 10 ignores the setting with a warning.

Explanation of Change

Adds a 7-day npm install cooldown (min-release-age) to protect against supply chain attacks, where compromised package versions are typically detected and unpublished within days of release.

  • .npmrc: min-release-age=7 — npm refuses to resolve versions published less than 7 days ago. Expensify-owned packages (@expensify/*, expensify-common, react-native-onyx, eslint-config-expensify) are exempt via min-release-age-exclude so internal releases install immediately.

Notes:

  • npm ci installs from the lockfile without re-resolving, so day-to-day CI/dev installs are unaffected. The cooldown applies when dependencies are added or updated — exactly the supply chain window it targets.
  • Urgent bypass: npm install <pkg> --min-release-age=0, or add the package to the exclude list.
  • Companion PR: https://github.com/Expensify/Mobile-Expensify/pull/14014 mirrors the .npmrc cooldown for HybridApp builds (App's postInstall.sh runs npm install in that repo).
  • No npm/node version changes here — the Node 26 upgrade ([No QA] Upgrade Node to 26.5.0 and npm to 11.17.0 #96205) provides npm 11.17.0 bundled, and dev VMs pick it up automatically via .nvmrc-based provisioning.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/636594

Tests

This is a tooling-only change with no runtime app code affected.

  1. On node 26.5.0 (nvm install), verify npm --version prints 11.17.0.
  2. Run npm ci and verify it completes without errors.
  3. Run npm install left-pad --dry-run (or any package with a release newer than 7 days) and verify npm resolves a version published at least 7 days ago.
  4. Run npm view expensify-common time --json and verify a hypothetical fresh internal release would still be installable (excluded packages resolve to their newest version).
  • Verify that no errors appear in the JS console

Offline tests

None — no runtime app code changes. npm install behavior offline is unchanged (installs resolve from cache/lockfile).

QA Steps

[No QA] — tooling-only change, no app behavior affected.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — tooling-only change, no UI.

Android: mWeb Chrome

N/A — tooling-only change, no UI.

iOS: Native

N/A — tooling-only change, no UI.

iOS: mWeb Safari

N/A — tooling-only change, no UI.

MacOS: Chrome / Safari

N/A — tooling-only change, no UI.

NicolasBonet and others added 2 commits July 16, 2026 18:22
Bump npm to 11.18.0 (first 11.x line with min-release-age-exclude) and
configure a 7-day install cooldown in .npmrc, exempting Expensify-owned
packages. CI installs npm 11 explicitly since Node 20 bundles npm 10.

Lockfile regenerated with npm 11: platform-specific optional deps
(@img/sharp-*) are now recorded, and optional peer dependencies are no
longer auto-installed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@NicolasBonet
NicolasBonet force-pushed the claude-npm-min-release-age branch from 2d26918 to 387a004 Compare July 16, 2026 23:22
The npm engine bump and setup-npm tooling are no longer needed: the Node 26
upgrade (#96205) ships npm 11.17.0 bundled, which already supports
min-release-age (added in npm 11.10.0).
@NicolasBonet NicolasBonet changed the title [No QA] Add npm min-release-age cooldown for supply chain protection [Hold App#96205] [No QA] Add npm min-release-age cooldown for supply chain protection Jul 17, 2026
@NicolasBonet NicolasBonet changed the title [Hold App#96205] [No QA] Add npm min-release-age cooldown for supply chain protection [HOLD App#96205][No QA] Add npm min-release-age cooldown for supply chain protection Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant