Make editable cell hover target full height#96318
Open
x-dev90 wants to merge 7 commits into
Open
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
x-dev90
marked this pull request as ready for review
July 17, 2026 15:15
melvin-bot
Bot
requested review from
nyomanjyotisa and
trjExpensify
and removed request for
a team
July 17, 2026 15:15
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@nyomanjyotisa I’m testing it now and will let you know once I’m done. Thanks. |
Contributor
Author
|
@nyomanjyotisa It’s ready for review. Thanks! |
Contributor
Author
|
@shawnborton, @dubielzyk-expensify could you please share you thoughts. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This follow-up updates editable table cells so the hover target covers the full row height while keeping the visual layout unchanged.
The editable cell now extends into the row’s vertical padding area, with matching inner padding so the content remains visually aligned.
Fixed Issues
$ #93242
PROPOSAL: #93242 (comment)
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-17.at.6.14.38.PM.mov
Android: mWeb Chrome
Screen_Recording_20260717_182625_Chrome.mp4
iOS: Native
Screen.Recording.2026-07-17.at.6.32.19.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-07-17.at.6.36.26.PM.mov
MacOS: Chrome / Safari
Screencast.From.2026-07-18.09-55-27.mp4