-
Notifications
You must be signed in to change notification settings - Fork 4k
Group bulk export options by integration for multi-workspace selections #96728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MelvinBot
wants to merge
9
commits into
main
Choose a base branch
from
claude-bulkExportMultiWorkspaceIntegration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9e18a7e
Group bulk export options by integration for multi-workspace selections
MelvinBot cdbe299
Group each integration's bulk export and mark-as-exported actions togβ¦
MelvinBot ea3fcb9
Add partial-export confirmation modal and fix already-exported detection
MelvinBot a5a54e7
Add subtitle prop to confirm modal; split bulk export modals into fixβ¦
MelvinBot bbf4133
Merge remote-tracking branch 'origin/main' into claude-bulkExportMultβ¦
MelvinBot b29fe7e
Export eligible subset per integration and split partial-export reasons
MelvinBot 9739a1a
Sync non-English exportPartialModal translations with latest English β¦
MelvinBot bbdbb84
Fix spellcheck: rename coined word markableReportIDs to reportIDsToMark
MelvinBot dd5c36d
Add integration-scoped accessibilityLabel to per-integration Mark as β¦
MelvinBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When selected reports span multiple integrations, this loop adds one
Mark as exporteditem per integration, but each item uses the same visible/accessibility text and no description, so the entries differ only by icon. In a QBO + Sage/NetSuite selection, usersβespecially keyboard or screen-reader usersβcannot tell which workspace integration will be marked, and choosing the wrong duplicate marks the wrong subset; include the integration name in the label or description.Useful? React with πΒ / π.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelvinBot keep the option text as-is since it matches OldDot, and add an
accessibilityLabelthat includes the integration name to fix the screen reader issue. For example:Mark as exported, QuickBooks Online.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done β kept the visible option text as
Mark as exportedand added anaccessibilityLabelthat includes the integration name, so screen readers can distinguish the per-integration entries (e.g.Mark as exported, QuickBooks Online). The "Export to β¦" options already use the integration name as their visible text, so no change was needed there.src/hooks/useSearchBulkActions.ts:1676Pushed as dd5c36d. Local checks:
npm run lint-changedβ ,npm run typecheck-tsgoβ ,npm test tests/unit/hooks/useSearchBulkActionsExportTest.tsβ (11 tests).