Skip to content

chore: upgrade react-native-keyboard-controller to 1.22.2 - #97082

Merged
mountiny merged 4 commits into
Expensify:mainfrom
software-mansion-labs:jakubstec/upgrade-react-native-keyboard-controller-to-1.22.2
Jul 29, 2026
Merged

chore: upgrade react-native-keyboard-controller to 1.22.2#97082
mountiny merged 4 commits into
Expensify:mainfrom
software-mansion-labs:jakubstec/upgrade-react-native-keyboard-controller-to-1.22.2

Conversation

@jakubstec

@jakubstec jakubstec commented Jul 27, 2026

Copy link
Copy Markdown
Member

Explanation of Change

Upgrades react-native-keyboard-controller from 1.21.0-beta.1 to 1.22.2. Updates the fix-insets-in-landscape patch to apply cleanly on the new version (renamed and re-applied, no functional changes to the patch itself), and refreshes package-lock.json and ios/Podfile.lock accordingly.

Fixed Issues

$ #97090
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14031

Tests

  1. Open any chat report and tap the composer to bring up the keyboard — verify the composer and message list resize smoothly with no jump or flicker.
  2. Type a message long enough to wrap multiple lines — verify the composer grows and the message list scrolls to keep the input visible.
  3. Open the attachment/emoji action sheet from the composer, then dismiss it — verify the keyboard spacing transitions correctly with no gap or overlap.
  4. On Android, rotate the device to landscape with the keyboard open on a chat report — verify the composer and safe area insets are correct (content isn't squeezed by the nav bar).
  5. Focus an input further down a scrollable form (e.g. a SelectionList search field) — verify the view auto-scrolls to keep the focused input visible above the keyboard.
  6. Verify the app builds and runs on iOS and Android with no regressions in keyboard-related behavior.

Offline tests

N/A — dependency version bump with no behavioral changes to networking.

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome

N/A — react-native-keyboard-controller is native-only; web/mWeb use a stub implementation unaffected by this upgrade.

iOS: Native
iOS: mWeb Safari

N/A — react-native-keyboard-controller is native-only; web/mWeb use a stub implementation unaffected by this upgrade.

MacOS: Chrome / Safari

N/A — react-native-keyboard-controller is native-only; web/mWeb use a stub implementation unaffected by this upgrade.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@jakubstec
jakubstec force-pushed the jakubstec/upgrade-react-native-keyboard-controller-to-1.22.2 branch from 0329de5 to 7ebd8e3 Compare July 27, 2026 10:30
@jakubstec
jakubstec marked this pull request as ready for review July 27, 2026 14:34
@jakubstec
jakubstec requested a review from a team as a code owner July 27, 2026 14:34
@melvin-bot
melvin-bot Bot requested review from chiragsalian and thesahindia July 27, 2026 14:35
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@thesahindia @chiragsalian One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 27, 2026 14:35
@mountiny

Copy link
Copy Markdown
Contributor

@thesahindia are you able to review this and the oldApp PR? https://github.com/Expensify/Mobile-Expensify/pull/14031

mountiny
mountiny previously approved these changes Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR has changes to package-lock.json that don't look related to the project. Like removing dev: true from the fsevents entry and removing the entire server/victory-chart-renderer/node_modules/react block. Can you double check.

@roryabraham

roryabraham commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

I keep seeing that same diff in a few places. I wonder why that's happening. I wonder if it has to do with the switch to Node 26?

@jakubstec

Copy link
Copy Markdown
Member Author

@chiragsalian I've reinstalled all node modules, and the diff stays the same. I think it's some metadata noise, won't affect anything.

chiragsalian
chiragsalian previously approved these changes Jul 28, 2026

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah thats weird. I don't quite get why thats happening but i guess we can debug that elsewhere.

@chiragsalian

Copy link
Copy Markdown
Contributor

@thesahindia, will you be able to review.

Comment thread package-lock.json Outdated
Comment thread package-lock.json Outdated
@thesahindia

Copy link
Copy Markdown
Member

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-07-29.at.12.27.01.PM.mov
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-07-29.at.9.49.28.AM.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

@mountiny

Copy link
Copy Markdown
Contributor

@jakubstec can you check the C+ comments please

@jakubstec
jakubstec dismissed stale reviews from chiragsalian and mountiny via cc7161d July 29, 2026 16:38

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner

@jakubstec

Copy link
Copy Markdown
Member Author

@thesahindia I must have been mistaken, after full git clean -fdx they disappeared, my bad 😄

@jakubstec

Copy link
Copy Markdown
Member Author

in fact, they disappeared on main branch, so it was not related to this PR 😳

@mountiny
mountiny merged commit c3b3689 into Expensify:main Jul 29, 2026
40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.46-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants