chore: upgrade react-native-keyboard-controller to 1.22.2 - #97082
Conversation
|
|
0329de5 to
7ebd8e3
Compare
|
@thesahindia @chiragsalian One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@thesahindia are you able to review this and the oldApp PR? https://github.com/Expensify/Mobile-Expensify/pull/14031 |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
chiragsalian
left a comment
There was a problem hiding this comment.
Your PR has changes to package-lock.json that don't look related to the project. Like removing dev: true from the fsevents entry and removing the entire server/victory-chart-renderer/node_modules/react block. Can you double check.
|
I keep seeing that same diff in a few places. I wonder why that's happening. I wonder if it has to do with the switch to Node 26? |
|
@chiragsalian I've reinstalled all node modules, and the diff stays the same. I think it's some metadata noise, won't affect anything. |
chiragsalian
left a comment
There was a problem hiding this comment.
Hmm yeah thats weird. I don't quite get why thats happening but i guess we can debug that elsewhere.
|
@thesahindia, will you be able to review. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-29.at.12.27.01.PM.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-07-29.at.9.49.28.AM.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
@jakubstec can you check the C+ comments please |
…ct-native-keyboard-controller-to-1.22.2
…eact-native-keyboard-controller-to-1.22.2
|
@thesahindia I must have been mistaken, after full |
|
in fact, they disappeared on main branch, so it was not related to this PR 😳 |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.46-0 🚀
|
Explanation of Change
Upgrades
react-native-keyboard-controllerfrom1.21.0-beta.1to1.22.2. Updates thefix-insets-in-landscapepatch to apply cleanly on the new version (renamed and re-applied, no functional changes to the patch itself), and refreshespackage-lock.jsonandios/Podfile.lockaccordingly.Fixed Issues
$ #97090
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14031
Tests
SelectionListsearch field) — verify the view auto-scrolls to keep the focused input visible above the keyboard.Offline tests
N/A — dependency version bump with no behavioral changes to networking.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
N/A —
react-native-keyboard-controlleris native-only; web/mWeb use a stub implementation unaffected by this upgrade.iOS: Native
iOS: mWeb Safari
N/A —
react-native-keyboard-controlleris native-only; web/mWeb use a stub implementation unaffected by this upgrade.MacOS: Chrome / Safari
N/A —
react-native-keyboard-controlleris native-only; web/mWeb use a stub implementation unaffected by this upgrade.