-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: Add Attendees to Edit multiple in expenses #97108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samranahm
wants to merge
12
commits into
Expensify:main
Choose a base branch
from
samranahm:94313/bulk-edit-Attendees
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
71b758c
Add bulk edit attendees route and ATTENDEES constant
samranahm 648a50f
Show Attendees in Edit Multiple when attendee tracking is enabled
samranahm 192e16e
hold shouldShowErrorMessage while loading
samranahm 6f5f343
update updateMultipleMoneyRequests and add attendees in EditMultiplePage
samranahm 6b2c5a5
Add tests for updating attendees in bulk edit transactions
samranahm fefa847
update saveAttendees logic
samranahm cc30be1
Impliment review feedbacks
samranahm 9994665
Show current attendee selected if all selected expense have same atte…
samranahm 64625f2
Merge remote-tracking branch 'upstream/main' into 94313/bulk-edit-Att…
samranahm a0cba15
Do not defult to any user to follow the same pattern as other fields
samranahm 74dcc59
Merge remote-tracking branch 'upstream/main' into 94313/bulk-edit-Att…
samranahm 9b2fd99
fix typecheck
samranahm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
src/pages/Search/SearchEditMultiple/SearchEditMultipleAttendeesPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import HeaderWithBackButton from '@components/HeaderWithBackButton'; | ||
| import ScreenWrapper from '@components/ScreenWrapper'; | ||
|
|
||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useOnyx from '@hooks/useOnyx'; | ||
|
|
||
| import {updateBulkEditDraftTransaction} from '@libs/actions/IOU/BulkEdit'; | ||
| import Navigation from '@libs/Navigation/Navigation'; | ||
|
|
||
| import MoneyRequestAttendeeSelector from '@pages/iou/request/MoneyRequestAttendeeSelector'; | ||
|
|
||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type {Attendee} from '@src/types/onyx/IOU'; | ||
|
|
||
| import {deepEqual} from 'fast-equals'; | ||
| import React, {useState} from 'react'; | ||
|
|
||
| function SearchEditMultipleAttendeesPage() { | ||
| const {translate} = useLocalize(); | ||
| const [draftTransaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_BULK_EDIT_TRANSACTION_ID}`); | ||
| const [attendees, setAttendees] = useState<Attendee[]>(() => draftTransaction?.comment?.attendees ?? []); | ||
|
|
||
| const saveAttendees = () => { | ||
| if (attendees.length <= 0) { | ||
| return; | ||
| } | ||
|
|
||
| const currentAttendees = draftTransaction?.comment?.attendees ?? []; | ||
| if (deepEqual(currentAttendees, attendees)) { | ||
| Navigation.goBack(); | ||
| return; | ||
| } | ||
|
|
||
| updateBulkEditDraftTransaction({comment: {attendees}}); | ||
| Navigation.goBack(); | ||
| }; | ||
|
|
||
| return ( | ||
| <ScreenWrapper | ||
| includeSafeAreaPaddingBottom | ||
| shouldEnableMaxHeight | ||
| testID="SearchEditMultipleAttendeesPage" | ||
| > | ||
| <HeaderWithBackButton | ||
| title={translate('iou.attendees')} | ||
| onBackButtonPress={Navigation.goBack} | ||
| /> | ||
| <MoneyRequestAttendeeSelector | ||
| onFinish={saveAttendees} | ||
| onAttendeesAdded={setAttendees} | ||
| attendees={attendees} | ||
| iouType={CONST.IOU.TYPE.SUBMIT} | ||
| shouldDeferEmptySelectionError | ||
| /> | ||
| </ScreenWrapper> | ||
| ); | ||
| } | ||
|
|
||
| export default SearchEditMultipleAttendeesPage; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.