Add Travel setup task to Getting Started section - #97133
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index b93ce71ab13..6c813111c4b 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1090,6 +1090,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: 'Sprechen Sie mit Ihrer Kundenbetreuung',
forGuidedSetup: 'für die geführte Einrichtung.',
configureApprovalsSubText: 'Berichtsfreigaben festlegen',
+ setupTravel: 'Reisen einrichten',
+ setupTravelSubText: 'Reisespezifische Regeln konfigurieren',
},
freeTrialSection: {
title: ({days}: {days: number}) => `Kostenlose Testversion: Noch ${days} ${days === 1 ? 'Tag' : 'Tage'}!`,
diff --git a/src/languages/es.ts b/src/languages/es.ts
index e1f165ef66e..4b3623e32ce 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1060,6 +1060,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToConcierge: 'Habla con Concierge',
forGuidedSetup: 'para la configuración guiada.',
configureApprovalsSubText: 'Definir aprobaciones de informes',
+ setupTravel: 'Configurar viajes',
+ setupTravelSubText: 'Configura reglas específicas de viaje',
},
upcomingTravel: 'Próximos viajes',
upcomingTravelSection: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 4a03311fb6a..67a8b2abaaa 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1106,6 +1106,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: 'Parlez à votre chargé de compte',
forGuidedSetup: 'pour la configuration guidée.',
configureApprovalsSubText: 'Définir les approbations de notes de frais',
+ setupTravel: 'Configurer les déplacements',
+ setupTravelSubText: 'Configurer des règles spécifiques aux déplacements',
},
yourSpend: {
title: 'Vos dépenses',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 87989bbae72..cc5d2f945bf 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1104,6 +1104,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: 'Parla con il tuo account executive',
forGuidedSetup: 'per la configurazione guidata.',
configureApprovalsSubText: 'Definisci le approvazioni dei report',
+ setupTravel: 'Configura viaggi',
+ setupTravelSubText: 'Configura regole specifiche per i viaggi',
},
yourSpend: {
title: 'Le tue spese',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 4e01b43eb90..82a787825bc 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1086,6 +1086,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: 'アカウントエグゼクティブに相談する',
forGuidedSetup: 'ガイド付きセットアップ用です。',
configureApprovalsSubText: 'レポート承認を定義する',
+ setupTravel: '出張を設定',
+ setupTravelSubText: '出張用のルールを設定する',
},
yourSpend: {
title: 'あなたの支出',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 611eed20ce1..278394f1290 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1102,6 +1102,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: 'Praat met je accountmanager',
forGuidedSetup: 'voor begeleide installatie.',
configureApprovalsSubText: 'Definieer rapportgoedkeuringen',
+ setupTravel: 'Reizen instellen',
+ setupTravelSubText: 'Reisspecifieke regels instellen',
},
yourSpend: {
title: 'Je uitgaven',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index c7708ce59b3..aec95ffb528 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1100,6 +1100,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: 'Porozmawiaj ze swoim opiekunem klienta',
forGuidedSetup: 'z prowadzeniem konfiguracji.',
configureApprovalsSubText: 'Zdefiniuj zatwierdzanie raportów',
+ setupTravel: 'Skonfiguruj podróże',
+ setupTravelSubText: 'Skonfiguruj zasady dotyczące podróży',
},
yourSpend: {
title: 'Twoje wydatki',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index f3364881612..e1a61e4e8a2 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1102,6 +1102,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: 'Fale com seu executivo de contas',
forGuidedSetup: 'para configuração guiada.',
configureApprovalsSubText: 'Definir aprovações de relatórios',
+ setupTravel: 'Configurar viagem',
+ setupTravelSubText: 'Configurar regras específicas de viagem',
},
yourSpend: {
title: 'Seus gastos',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 22f87d88446..958bddca1a1 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1069,6 +1069,8 @@ const translations: TranslationDeepObject<typeof en> = {
talkToAccountExecutive: '联系您的客户经理',
forGuidedSetup: '以获取引导式设置。',
configureApprovalsSubText: '定义报表审批',
+ setupTravel: '设置差旅',
+ setupTravelSubText: '配置差旅专用规则',
},
yourSpend: {title: '您的支出', awaitingApproval: '等待审批', repaidLast30Days: '过去30天内已偿还', recentTransactions: ({lastFour}: {lastFour: string}) => `最近交易 • ${lastFour}`},
seeMore: ({count}: {count: number}) => `再查看 ${count} 个`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@daledah @abzokhattab @linhvovan29546 please ignore the ping |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 618cb57592
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.46-0 🚀
|
Help site review — no changes requiredI reviewed this PR against What this PR does: adds a conditional Setup travel task to the Home Getting started checklist. It appears once Travel is enabled on the policy and clears once the workspace is provisioned ( Why no docs change:
Per the authoring guidelines (one workflow per article, UI-exact labels, no feature-hub padding), adding a line for a single conditional onboarding nudge to the general overview article would go against the article's intentional altitude, so I've left it as-is. If you'd prefer the overview article to explicitly call out the Setup travel task anyway, reply and I'll open the draft PR. @blimpich — no linked help site PR was created because I found no required docs change. If you disagree, let me know and I'll draft one. |
4 participants
Explanation of Change
Coming from this slack thread. Admins who turn on the Travel workspace feature (via onboarding or Workspace Settings) but never complete the one-time Spotnana provisioning process are left with Travel "enabled" but never actually usable by their employees, with no reminder to finish setup. This adds a "Setup travel" task to the home screen's Getting Started section, following the same pattern as the existing "Issue Expensify cards" / "Link company cards" rows: it appears once Travel is enabled on the policy, and clears once the workspace is provisioned (
travelSettings.spotnanaCompanyIDset).Fixed Issues
$ https://github.com/Expensify/Expensify/issues/664889
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos