[HOLD Auth 23253][HOLD expensify-common 935][HOLD web-e 54892] Add reasonCodes for shipping cards - #97157
Draft
chuckdries wants to merge 5 commits into
Draft
[HOLD Auth 23253][HOLD expensify-common 935][HOLD web-e 54892] Add reasonCodes for shipping cards#97157chuckdries wants to merge 5 commits into
chuckdries wants to merge 5 commits into
Conversation
…-ship-and-replace-card
…-ship-and-replace-card
…-ship-and-replace-card
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Author
|
I'll take this out of draft once the backend is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The big picture is we're introducing reasonCode, a parameter you pass to ResendValidateCode that binds that specific validateCode to only be used for the intended purpose. This PR implements
SHIP_CARD,REPLACE_CARDandREPORT_CARD_FRAUD.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/623748
PROPOSAL:
Tests
Ship card
Replace physical card
Report virtual card fraud
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari