[CP Staging] Fix: keep "Add receipt" label on one line in compact confirmation banner by MelvinBot · Pull Request #97207 · Expensify/App

MelvinBot · 2026-07-28T08:40:40Z

Explanation of Change

On the expense confirmation page, the compact "Add receipt" banner renders its label as a plain <Text> inside a fixed-height (52dp), overflow: 'hidden' container. At minimum system font size the label wraps to a second line and the clipped overflow leaves only "Add" visible instead of "Add receipt".

This adds a single-line guard to the compact label so it can never wrap out of the fixed-height banner: numberOfLines={1} plus styles.flexShrink1 so it truncates gracefully if space is ever tight, matching how the shared Button handles its icon + label row. The fixed height/overflow are intentionally kept — they preserve the intended compact banner size; the real defect was the missing wrap guard.

Fixed Issues

$ #97153
PROPOSAL: #97153 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Device is Android 16.
Set font size to minimum.

Test steps:

Launch Expensify app.
Go to workspace chat.
Tap + > Create expense > Manual.
Enter amount > Next.

Expected Result:

"Add receipt" will be shown on confirm page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Co-authored-by: Issa Nimaga <inimaga@users.noreply.github.com>

MelvinBot · 2026-07-28T08:49:12Z

I analyzed the failing checks. All code, build, and test checks pass — typecheck, all 8 test jobs, ESLint, Oxfmt, Bun tests, Storybook tests, knip, perf tests, and builds are green.

The only failing check is PR Author Checklist / checklist, and its failure reason is:

PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

There's no code fix to push for this — it fails solely because the checkboxes in the PR description (the platform testing affirmations, the Tests/QA Steps sections, etc.) are still unchecked. Those are human affirmations (e.g. "I ran the tests on all platforms & verified they passed"), so I can't check them off on your behalf.

To clear this check: fill out the Tests / QA Steps sections and tick the author-checklist boxes in the PR description, and it'll re-run and pass.

melvin-bot · 2026-07-28T09:13:32Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-07-28T09:16:13Z

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

inimaga · 2026-07-28T11:35:56Z

@emkhalid Could you take over testing of this PR instead of raising a new one

emkhalid · 2026-07-28T11:53:28Z

@emkhalid Could you take over testing of this PR instead of raising a new one

On it, thanks

emkhalid · 2026-07-28T11:57:08Z

Repro:

trjExpensify

I think this should get a @Expensify/design review.

trjExpensify · 2026-07-28T12:00:56Z

Also, swapping in @flaviadefaria as this was yours. 👍

MelvinBot · 2026-07-28T12:01:39Z

Re-checked: all code, build, and test checks are still green. The only failing check is now PR Reviewer Checklist / checklist (it triggered because a review was submitted).

Like the author checklist, this isn't a code defect I can push a fix for — it fails only because the reviewer-checklist boxes aren't all ticked. That's a reviewer affirmation, so the assigned reviewer needs to complete their checklist to clear it. There's nothing for me to commit here.

emkhalid · 2026-07-28T12:04:24Z

@inimaga I reproduced the issue and confirmed this PR fixes it with minimum font and display sizes.

inimaga · 2026-07-28T12:17:12Z

I think this should get a @Expensify/design review.

@trjExpensify This PR is a minor follow-up to the PR #96203 in order to fix the deploy blocker at #97153

The original design had been approved and this adjustment is fixing an edge case specific to Android devices with minimum system font size.

inimaga · 2026-07-28T12:17:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

inimaga · 2026-07-28T12:19:24Z

Need to get an additional review here because I instructed MelvinBot to create the PR.

rlinoz · 2026-07-28T12:22:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-07-28T12:25:47Z

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-28T12:29:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-28T12:31:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97207.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-795aa902cf3-38e8a32-713b5bcc1ccaf913d85f6bd763c3b03fbf101ca3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-795aa90-38e8a32-cae76280d03bbede296ef6cb99a8df1eaf3c35d6/index.html

Web 🕸️
https://97207.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…uard Fix: keep "Add receipt" label on one line in compact confirmation banner (cherry picked from commit 795aa90) (cherry-picked to staging by lakchote)

OSBotify · 2026-07-28T13:00:43Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.45-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-28T13:02:18Z

⚠️ Claude's API is experiencing issues. Check status.anthropic.com for updates and try again once the incident resolves.

Run details

Fix: keep Add receipt label on one line in compact banner

fa70e52

Co-authored-by: Issa Nimaga <inimaga@users.noreply.github.com>

MelvinBot assigned inimaga Jul 28, 2026

MelvinBot requested a review from a team July 28, 2026 08:40

MelvinBot mentioned this pull request Jul 28, 2026

Android - Expense - "Add" is shown instead of "Add receipt" on confirm page #97153

Closed

7 tasks

inimaga marked this pull request as ready for review July 28, 2026 09:13

inimaga requested a review from a team as a code owner July 28, 2026 09:13

melvin-bot Bot requested review from sobitneupane and removed request for a team July 28, 2026 09:13

melvin-bot Bot requested review from trjExpensify and removed request for a team July 28, 2026 09:13

This comment has been minimized.

Sign in to view

trjExpensify reviewed Jul 28, 2026

View reviewed changes

trjExpensify requested a review from flaviadefaria July 28, 2026 12:01

inimaga assigned emkhalid and inimaga and unassigned inimaga Jul 28, 2026

inimaga approved these changes Jul 28, 2026

View reviewed changes

rlinoz approved these changes Jul 28, 2026

View reviewed changes

lakchote approved these changes Jul 28, 2026

View reviewed changes

inimaga merged commit 795aa90 into main Jul 28, 2026
48 of 50 checks passed

inimaga deleted the claude-addReceiptSingleLineGuard branch July 28, 2026 12:23

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 28, 2026

inimaga changed the title ~~Fix: keep "Add receipt" label on one line in compact confirmation banner~~ [CP Staging] Fix: keep "Add receipt" label on one line in compact confirmation banner Jul 28, 2026

OSBotify mentioned this pull request Jul 28, 2026

Deploy Checklist: New Expensify 2026-07-27 #97134

Open

Uh oh!

Conversation

MelvinBot commented Jul 28, 2026 • edited by inimaga Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Precondition:

Test steps:

Expected Result:

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Jul 28, 2026

Uh oh!

melvin-bot Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

This comment has been minimized.

inimaga commented Jul 28, 2026

Uh oh!

emkhalid commented Jul 28, 2026

Uh oh!

emkhalid commented Jul 28, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Jul 28, 2026

Uh oh!

MelvinBot commented Jul 28, 2026

Uh oh!

emkhalid commented Jul 28, 2026

Uh oh!

inimaga commented Jul 28, 2026

Uh oh!

inimaga commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

inimaga commented Jul 28, 2026

Uh oh!

rlinoz commented Jul 28, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

MelvinBot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MelvinBot commented Jul 28, 2026 •

edited by inimaga

Loading

inimaga commented Jul 28, 2026 •

edited

Loading