fix: keep Search Router results above offline indicator - #97211
Draft
nabi-ebrahimi wants to merge 2 commits into
Draft
fix: keep Search Router results above offline indicator#97211nabi-ebrahimi wants to merge 2 commits into
nabi-ebrahimi wants to merge 2 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When Search Router is opened offline on a narrow layout, the sticky offline indicator overlays the bottom of the results list. If FlashList determines that its content fits, scrolling does not begin and the keyboard remains open, leaving the final result inaccessible.
This adds offline-indicator bottom clearance to the Search Router list using the existing
useBottomSafeSafeAreaPaddingStylehook. The additional clearance applies only on narrow layouts while offline. Online and wide-layout behavior remains unchanged.Fixed Issues
$ #97182
PROPOSAL: <PROPOSAL_COMMENT_URL>
Tests
Tests
Online Search Router regression
go to.Expected: Results display normally, scrolling works when needed, and the selected destination opens.
Short result list
account.Expected: The short list remains positioned normally without unnecessary visible spacing, and selection works.
Keyboard closed
go to.Expected: All results remain accessible and navigation works.
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari