Skip to content

[No QA] Remove unsafe type assertions from policy, workflow, navigation, and utility tests - #97317

Draft
KJ21-ENG wants to merge 4 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt/cleanup-20260728-tests-01
Draft

[No QA] Remove unsafe type assertions from policy, workflow, navigation, and utility tests#97317
KJ21-ENG wants to merge 4 commits into
Expensify:mainfrom
KJ21-ENG:seatbelt/cleanup-20260728-tests-01

Conversation

@KJ21-ENG

Copy link
Copy Markdown
Contributor

Explanation of Change

This test-only cleanup removes 137 redundant @typescript-eslint/no-unsafe-type-assertion findings from the ten authorized test files. It replaces them with production-derived types, typed mocks, and key-specific Onyx fixtures while preserving the existing test scenarios and runtime behavior. Intentional malformed custom-unit error fixtures retain their exact backend payload through a localized typed helper.

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Count change

Current baseline source:

  • tests/actions/WorkflowTest.ts: 13 findings
  • tests/navigation/getStateFromPathTests.ts: 14 findings
  • tests/perf-test/useFilterFormValues.perf-test.tsx: 14 findings
  • tests/unit/FileUtilsTest.ts: 13 findings
  • tests/unit/PolicyUtilsTest.ts: 13 findings
  • tests/unit/SearchEditMultipleUtilsTest.ts: 14 findings
  • tests/unit/hooks/useAutoCreateSubmitWorkspace.test.ts: 13 findings
  • tests/unit/navigateToWorkspacesPageTest.ts: 14 findings
  • tests/unit/selectors/PolicyTest.ts: 15 findings
  • tests/unit/usePolicyIndicatorChecksTest.ts: 14 findings

Before:

  • 137 @typescript-eslint/no-unsafe-type-assertion findings across the ten target files

After:

  • 0 @typescript-eslint/no-unsafe-type-assertion findings in every target file

Net reduction:

  • 137 fewer findings across the ten target files

TSV evidence:

  • The tracked config/eslint/eslint.seatbelt.tsv at base 2c95456c78d65e54730dcde1f758292472ab59fa provides the baseline counts above. Final cleanup-count verification at exact head ea332a6781c6813b874687ac0446634857edbb3e reported zero remaining findings for every target, and the tracked TSV was restored unchanged.

Tests

  1. Focused cleanup-count verification, formatting, and individually scoped lint checks passed for all ten targets.
  2. Focused unit tests passed: 9 suites and 479 tests.
  3. The focused useFilterFormValues.perf-test.tsx suite passed: 1 suite and 11 tests, including Reassure verification.
  4. Fork CI run 30431382868 passed typecheck, lint, format, React Compiler, and Jest for exact head ea332a6781c6813b874687ac0446634857edbb3e.
  5. Full App typecheck was not run locally; Fork CI is authoritative for that check.
  6. No manual platform testing was performed; the evidence is automated verification only.

Offline tests

Not applicable: this is a test-only type-safety cleanup and changes no product runtime or network behavior.

QA Steps

No QA required for this test-only cleanup; the title starts with [No QA] and no staging or production manual QA was performed.

PR Author Checklist

Checklist note: every item below is checked to record that it was considered. Platform, staging or production, offline, screenshot or video, high-traffic, and product-component testing are N/A for this test-only cleanup; no manual platform or product testing is claimed. The automated evidence is listed in ### Tests.

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — no UI changes; no screenshots or videos were produced.

Changed files (10)

  • tests/actions/WorkflowTest.ts
  • tests/navigation/getStateFromPathTests.ts
  • tests/perf-test/useFilterFormValues.perf-test.tsx
  • tests/unit/FileUtilsTest.ts
  • tests/unit/PolicyUtilsTest.ts
  • tests/unit/SearchEditMultipleUtilsTest.ts
  • tests/unit/hooks/useAutoCreateSubmitWorkspace.test.ts
  • tests/unit/navigateToWorkspacesPageTest.ts
  • tests/unit/selectors/PolicyTest.ts
  • tests/unit/usePolicyIndicatorChecksTest.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant