Add the QBO currency conversion fee account picker

[ishpaul777]

Explanation of Change

When a company covers the currency conversion on a cross-border reimbursement, its bank is debited more than the reimbursement. We now export a journal entry recording that extra spend, and it needs a GL account to debit. This adds the picker that sets it, on the QBO advanced page next to the existing bill payment and invoice collections rows.

The account list is a new expenseAccounts collection holding profit and loss accounts only. Every list QBO ships today is balance sheet accounts, which would park a fee where it never reaches the P&L.

Draft because it depends on two unmerged PRs: Integration-Server #9182 produces expenseAccounts and consumes the setting, and Auth #23645 allowlists the key so the write is accepted. Until the first lands and a policy re-syncs QBO, this picker shows its empty state, so screenshots are not worth taking yet.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/655938
PROPOSAL: N/A, internal

Tests

1. Connect a workspace to QuickBooks Online and sync it.
2. Go to Workspace > Accounting > QuickBooks Online > Advanced.
3. Turn on Sync reimbursed reports.
4. Confirm a "QuickBooks Online currency conversion fee account" row appears under the bill payment and invoice collections rows.
5. Tap it and confirm the list holds expense accounts only, no bank or accounts payable entries.
6. Pick one, confirm it saves and the row shows the account name.
7. Reopen the selector and confirm that account is the selected one.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline.
2. Pick a different account.
3. Confirm the row updates optimistically and greys out.
4. Go back online and confirm the choice sticks.

QA Steps

Same as tests. Requires a QuickBooks Online connected workspace.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Pending. The selector renders empty until Integration-Server #9182 merges and a policy syncs QBO, so these come before this leaves draft.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	94.85% <ø> (+0.03%)	⬆️
src/SCREENS.ts	100.00% <ø> (ø)
src/libs/API/types.ts	100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	66.66% <ø> (ø)
src/libs/actions/connections/QuickbooksOnline.ts	29.67% <100.00%> (+2.83%)	⬆️
src/ROUTES.ts	23.44% <0.00%> (+0.04%)	⬆️
...gation/AppNavigator/ModalStackNavigators/index.tsx	6.37% <0.00%> (-0.02%)	⬇️
...accounting/qbo/advanced/QuickbooksAdvancedPage.tsx	0.00% <0.00%> (ø)
.../advanced/QuickbooksFxExpenseAccountSelectPage.tsx	0.00% <0.00%> (ø)
... and 303 files with indirect coverage changes

[ishpaul777]

@MelvinBot review

[ishpaul777]

@codex review

[MelvinBot]

🤖 Review — this is well-structured. The new picker, action, and selector page are near-exact clones of the existing invoice-collection-account flow, tests cover the action, and all 11 locales are updated. No blocking issues. A couple of minor observations below.

What I checked

• Action (QuickbooksOnline.ts:434-451) — matches updateQuickbooksOnlineCollectionAccountID exactly: same short-circuit guard (settingValue === oldSettingValue || !policyID), same JSON.stringify(settingValue) over the wire, same idempotency key derivation. ✅
• Selector page (QuickbooksFxExpenseAccountSelectPage.tsx) — a faithful copy of QuickbooksInvoiceAccountSelectPage.tsx, reading from the new expenseAccounts collection and writing fxExpenseAccount. Empty-state keys (noAccountsFound / noAccountsFoundDescription) exist. ✅
• Advanced page row (QuickbooksAdvancedPage.tsx:92-100) — added to AccordionMenuItems, so it only renders when the Sync reimbursed reports accordion is expanded, matching the test plan. Subscribes to fxExpenseAccount for brick-road / pending / offline feedback. ✅
• Wiring — ROUTES, SCREENS, SCREENS→RHP relation, linking config, navigator param list, and modal stack lazy-require are all consistent with the sibling invoice selector. ✅
• Tests (tests/actions/connections/QuickbooksOnline.ts) — command name, quoted settingValue, optimistic update + failure revert, and both skip paths (unchanged value, missing policyID) are all covered. I couldn't execute jest in this environment, but the cases mirror the existing passing suite.

Minor observations (non-blocking):

1. Field naming — Policy.ts:561 stores an account ID as fxExpenseAccount, whereas its siblings that also hold IDs are suffixed (reimbursementAccountID, collectionAccountID). Assuming this exactly matches the Auth allowlist key from Auth #23645, keep it — just worth a comment noting the value is an ID so it isn't mistaken for the Account object that reimbursableExpensesAccount holds.

2. Draft dependencies — nothing to act on, just flagging that this can't leave draft (or be QA'd) until Integration-Server #9182 lands and a policy re-syncs so expenseAccounts is populated; until then the picker only shows its empty state, as the description notes.

I did not run the web app for this since it needs a QBO-connected workspace and the unmerged backend to populate expenseAccounts — runtime verification is best done once #9182 is in, per your own note.

---

Reply with @MelvinBot <feedback> to refine.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 8c8aa7cd98

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".