Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci packing #2

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Feature/ci packing #2

merged 13 commits into from
Sep 26, 2024

Conversation

Kola50011
Copy link
Member

No description provided.

@Kola50011 Kola50011 self-assigned this Sep 24, 2024
Copy link
Member

@christoph-heiss christoph-heiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the -Werror stuff and the CI failure due to the cmake invocation, LGTM.

@Kola50011 Kola50011 dismissed christoph-heiss’s stale review September 25, 2024 20:08

incorporated already

@Kola50011
Copy link
Member Author

Should be good now. Pls approve and merge

@christoph-heiss christoph-heiss merged commit d5885d4 into master Sep 26, 2024
1 check passed
@christoph-heiss christoph-heiss deleted the feature/ci-packing branch September 26, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants