Feature/set operation functions #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylon
reviewed
Dec 29, 2025
Collaborator
dylon
left a comment
dylon
left a comment
There was a problem hiding this comment.
I did a bit of experimentation and could not find a dataset size or structure depth at which PathMap-based set operations outperformed HashMap-based ones. HashMap utilizes the hardware caches better than PathMap for generalized set operations. PathMap excels at prefix querying and incremental updates when structural sharing benefits can be maximized, but it is not the best for implementing generalized set operations (according to my benchmarks).
I pushed my experimental branch, based off this one, to dylon/set-operation-functions:
- HashMap-based set operations: src/backend/eval/set.rs
- Empirical benchmark analysis: crossover_analysis.md
- Commit diff: d90d2d597eb16fa1392846d7a3a09a2d51f21362
…enchmarks parallel PathMap multiset operations vs. sequential HashMap operations and demonstrates, empirically, that the HashMap-based operations perform better than the PathMap-based operations regardless the dataset size or depth of structures
SerhiiL-DevBrother
force-pushed
the
feature/set-operation-functions
branch
2 times, most recently
from
24e4b59 to
aa0ed51
Compare
SerhiiL-DevBrother
force-pushed
the
feature/set-operation-functions
branch
from
aa0ed51 to
b960999
Compare
9 tasks
SerhiiL-DevBrother
force-pushed
the
feature/set-operation-functions
branch
from
b960999 to
dd46d7c
Compare
dylon
approved these changes
Jan 5, 2026
Collaborator
dylon
left a comment
dylon
left a comment
There was a problem hiding this comment.
Looks good! Thanks, Serhii.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.