Rename rust-node to hybrid-node, add pure Rust build #303
+222
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force recompile workspace crates after copying source to prevent stale cache from dummy dependency files causing module resolution errors.
Prevents Docker layer caching from preserving stale compilation state between the clean and build steps. Also adds --target flag to cargo clean to ensure correct target directory is cleaned.
| esac && \ | ||
| rustup target add $LINUX_TARGET && \ | ||
| echo "Cleaning workspace crates to force rebuild with real source..." && \ | ||
| cargo clean -p shared -p crypto -p models -p casper -p comm \ |
Collaborator
There was a problem hiding this comment.
With this cleanup there would be no sense in building dependencies upfront.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary: Rename Docker Images - Hybrid vs Pure Rust
Overview
Rename the current SBT-built Docker image from
f1r3fly-rust-nodetof1r3fly-hybrid-nodeand reservef1r3fly-rust-nodefor the pure Rust image built fromnode/Dockerfile.Changes
build.sbtf1r3fly-rust-node→f1r3fly-hybrid-node.github/workflows/build-test-and-deploy.ymlbuild_docker_image→build_hybrid_docker_image(producesartifacts-hybrid-docker)build_rust_docker_imagejob (producesartifacts-rust-docker)release_rust_docker_imagejob for pure Rust imagerelease_docker_image→release_hybrid_docker_imageREADME.mdnode/Dockerfilecargo cleanfor workspace crates after copying sourceDocker Hub Images (After Merge)
f1r3fly-rust-nodenode/Dockerfilef1r3fly-hybrid-nodeNo Changes Required
f1r3fly-rust-node)f1r3fly-rust-node)integration-tests/Dockerfile(already referencesf1r3fly-rust-node)