Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] add component FAB, radio button, and textfield #16

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

Nia-Dalimunthe
Copy link
Collaborator

Adding new components: floating action button, radio button, and text field.

@Nia-Dalimunthe Nia-Dalimunthe added the enhancement New feature or request label Jul 12, 2024
Copy link
Collaborator

@daffahilmyf daffahilmyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix

@@ -1,12 +1,12 @@
import './App.css';
import { EntryButton } from '@organisms/EntryButton';
//import { EntryButton } from '@organisms/EntryButton';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all commented code

@@ -0,0 +1,30 @@
import { TextField as TextFieldMUI } from '@mui/material';
//import { ReactNode } from 'react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

@@ -9,7 +9,7 @@ describe('Checkbox', () => {
render(
<Checkbox
testId='checkbox_test'
variant='contained'
//variant='contained'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

Copy link
Collaborator

@daffahilmyf daffahilmyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@daffahilmyf daffahilmyf merged commit e863906 into stage Jul 24, 2024
3 checks passed
@daffahilmyf daffahilmyf deleted the nia/component branch July 24, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants