Skip to content

Commit

Permalink
✨feat: add webtools checkDefaultBrowser and rm v8-cache
Browse files Browse the repository at this point in the history
  • Loading branch information
BoyYangzai committed Jun 26, 2023
1 parent d6e7d56 commit 197bb61
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 5 deletions.
1 change: 0 additions & 1 deletion packages/core/bin/doctor.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/usr/bin/env node

require("v8-compile-cache");
require("../dist/cli/cli")
.run()
.catch((e) => {
Expand Down
3 changes: 2 additions & 1 deletion packages/web-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"dependencies": {
"@doctors/utils": "workspace:^",
"@umijs/core": "^4.0.71",
"@umijs/utils": "^4.0.71"
"@umijs/utils": "^4.0.71",
"default-browser": "^4.0.0"
}
}
6 changes: 4 additions & 2 deletions packages/web-tools/src/features/checkChrome.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { exec } from "child_process";
import { IApi } from "../type";
const os = require("os");
import { IApi } from "../type";
import { DoctorLevel } from "@doctors/core";

let str: string = "";
if (os.platform() === "darwin") {
str =
Expand Down Expand Up @@ -43,7 +45,7 @@ export default (api: IApi) => {
return {
label: "isChromeInstalled",
description: "You should apply Chrome for web development",
doctorLevel: "success",
doctorLevel: DoctorLevel.SUCCESS,
};
}
});
Expand Down
27 changes: 27 additions & 0 deletions packages/web-tools/src/features/checkDefaultBrowser.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { DoctorLevel } from "@doctors/core";
import { IApi } from "../type";
import { chalkByDoctorLevel } from "@doctors/utils";

export default (api: IApi) => {
api.addDoctorWebToolsCheck(async () => {
const defaultBrowser = await import("default-browser");
const defaultBrowserName = (await defaultBrowser.default()).name;
const description = `Set the Chrome as default browser is best ${chalkByDoctorLevel(
DoctorLevel.SUCCESS,
`Now: ${defaultBrowserName}`
)}`;
if (defaultBrowserName === "Chrome") {
return {
label: "Default Browser",
description,
doctorLevel: DoctorLevel.SUCCESS,
};
} else {
return {
label: "Default Browser",
description,
doctorLevel: DoctorLevel.WARN,
};
}
});
};
1 change: 1 addition & 0 deletions packages/web-tools/src/features/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export default [
require.resolve("./checkNode"),
require.resolve("./checkChrome"),
require.resolve("./checkDefaultBrowser"),
];
5 changes: 4 additions & 1 deletion packages/web-tools/src/type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ interface Meta {}
export type IApi = DoctorApi & {
addDoctorWebToolsCheckBefore: (fn: () => void) => void;

addDoctorWebToolsCheck: (fn: (meta: Meta) => DoctorMeta) => void;
addDoctorWebToolsCheck: {
(fn: (meta?: Meta) => DoctorMeta | undefined): void;
(fn: (meta?: Meta) => Promise<DoctorMeta | undefined>): void;
};

addDoctorWebToolsCheckEnd: (fn: () => void) => void;
};

0 comments on commit 197bb61

Please sign in to comment.