Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add web-tools check, checkRegistry #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CoderSerio
Copy link
Contributor

用于检测当前npm yarn pnpm下载源是否稳定。
这里判定稳定的标准是,1. 广泛使用的 2. 没有被标记为废弃

如果没有安装yarn pnpm,那么下载源被判定为undefined且标记为WARN

// 广泛使用的
const commonRegistryHosts = [
  "registry.npmjs.org", // npm
  "registry.yarnpkg.com", // yarn
  "mirrors.cloud.tencent.com", // tencent
  "r.cnpmjs.org", // cnpm
  "registry.npmmirror.com", // taobao
  "skimdb.npmjs.com", // npmMirror
];

// 废弃的
const deprecatedRegistryHosts = [
  "registry.npm.taobao.org", // taobao
];

@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doctor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 8:27pm

@BoyYangzai
Copy link
Member

BoyYangzai commented Jun 30, 2023

@CoderSerio
Discussions:
For web-tools 全局 npm 源
1.有不少大厂都是自己私有的 npm 源 ,这个情况好像没有考虑到
2. - 如果没有安装yarn pnpm,那么下载源被判定为undefined且标记为WARN
这个得考虑一下情况 很多项目都有历史包袱 是否一定需要 yarn pnpm? 给予warning npm源应该建立在有yarn pnpm的基础上
可以编写 通用的 checkYarn/PnpmExist 函数放在 utils 中,感觉这个检测会在其他包也用到

这个 pr 只做前者

For @doctors/common 项目
感觉这里可以在 @doctors/common 就是针对普通应用项目中也加上
针对 .npmrc 文件来入手
checkNpmrc 线检察这个文件是否存在 如果不存在 WARN:请创建 .npmrc 文件 并指定 registry 源
如果有 .npmrc 文件 再去检测 他指定的 registry 源是否是废弃的?
最佳实践应该围绕最好添加 .npmrc 文件来入手

@CoderSerio
Copy link
Contributor Author

get,我这里的考虑确实不太全面,今天晚一点我尝试调整一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants