Implications no longer include multiple variants #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkRampersad
force-pushed
the
subject_tx_dx_implication_parameter
branch
from
4026530 to
c108624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have changed the find_subject_dx_implication and find_subject_tx_implication parameters to no longer include multiple variants/genotype profiles for one implication .This issue surfaced when the implications were expanded to no longer house the variants/genotype profiles and they aforementioned profiles were their own parameter in the bundle.
How Has This Been Tested?
I ran the test without the OVERWRITE env var to make sure the only thing being thrown back was assertion errors (no errors affecting fetches or other functions). I then ran the tests using the env var OVERWRITE_TEST_EXPECTED_DATA=true and checked the difference in the outputs. From what I can tell the variants are removed. My next feature is to making the diff-ing of expected outputs easier to read (standardizing order is a start)