Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event card enhancements #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

badrinarayanms
Copy link

@badrinarayanms badrinarayanms commented Jan 3, 2025

Description

This PR enhances the event card component by:

  • Adding a hover effect that displays the 'View on Map' and 'Register' buttons.
  • Implementing a countdown timer to show how many days are left before the event starts.
  • Updating the events.json to include a new map attribute for the event location URL.

These changes aim to improve user interaction and provide event details in a more engaging way.

Files Changed

  • EventCard.js: Updated to display buttons on hover and added a Countdown component that shows the number of days until the event starts.
  • events.json: Added a new map attribute for the event location URL.

This image shows the updated event card with the hover effect for the 'View on Map' and 'Register' buttons, as well as the countdown timer displaying the days remaining before the event starts.
out

@JustinBenito
Copy link
Contributor

Amazing work @badrinarayanms
really a thoughtful addition to the application.
I have few suggestions that we can discuss:
adding a map attribute to the events.json would be a bit redundant since we are already getting the venue and it just means more effort on the contributors side which is something that we are trying to avoid for now.
If possible to get the map link from the existing venue property it would be really great.

The starts in x days is a great addition, and an amazing one.
But I just feel it might get cluttered with a lot of info really quick.
So for now I would request you to merge this into a new branch that we will create for future releases.
Since this is v0.01 we are thinking about bringing in people and contributors to the application than scaling up real quick.
But this would be a great addition in the coming months.

I'll create a timeline of releases and will also create a branch and will let you know and you can merge the changes to that branch which we can use over time.

Thanks a lot for your valuable time and effort.
Cheers :)

@hareesh-r
Copy link
Contributor

Hey @badrinarayanms adding this is a great feature to have. But adding another extra field to this small card will make the UI cluttered. It would be easy for us to decide if you can show us the Mock UI after expanding the Card's minimum dimensions to fit in all the details yet having enough space to make it look less cluttered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants