-
Notifications
You must be signed in to change notification settings - Fork 1
구현 과제 - 로그인/회원가입 모달 - 모건 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
redcontroller
wants to merge
3
commits into
main
Choose a base branch
from
11-morGan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="ko"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>로그인 페이지</title> | ||
| <link rel="stylesheet" href="./style.css"> | ||
| </head> | ||
|
|
||
| <body> | ||
| <section class="section"> | ||
| <header class="header"> | ||
| <h1>로그인 또는 회원가입</h1> | ||
| <button type="button"><span class="a11y-hidden">닫기 버튼</span></button> | ||
| </header> | ||
| <main class="main"> | ||
| <article class="normal-login"> | ||
| <h2>위니브에서 여러분의 궁금증을 해결하세요! :)</h2> | ||
|
|
||
| <form class="form"> | ||
| <label class="a11y-hidden" for="input-id">아이디</label> | ||
| <input class="input" id="input-id" type="text" placeholder="아이디"> | ||
| <p class="id-alert">아이디를 입력해주세요</p> | ||
| <label class="pw a11y-hidden" for="input-pw">비밀번호</label> | ||
| <input class="input pw" id="input-pw" type="text" placeholder="비밀번호"> | ||
| <p class="pw-alert">아이디 혹은 비밀번호과 일치하지 않습니다.</p> | ||
| <input class="input-hold hide" id="checkbox-login" type="checkbox"> | ||
| <label class="label-hold" for="checkbox-login">로그인 상태 유지</label> | ||
| <button class="btn member" type="submit">로그인</button> | ||
| </form> | ||
| <div> | ||
| <a href="./">회원가입</a> | ||
| <a href="./">아이디/비밀번호 찾기</a> | ||
| </div> | ||
| </article> | ||
| <article class="sns-login"> | ||
| <p>또는</p> | ||
|
|
||
| <ul class="sns-group"> | ||
| <li> | ||
| <a class="btn google" href="./">구글 계정으로 로그인</a> | ||
| </li> | ||
| <li> | ||
| <a class="btn facebook" href="./">페이스북 계정으로 로그인</a> | ||
| </li> | ||
| <li> | ||
| <a class="btn naver" href="./">네이버 계정으로 로그인</a> | ||
| </li> | ||
| <li> | ||
| <a class="btn kakao" href="./">카카오톡 계정으로 로그인</a> | ||
| </li> | ||
| </ul> | ||
| </article> | ||
| </main> | ||
| </section> | ||
| <ul> | ||
| </body> | ||
|
|
||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
웹접근성을 고려해서 a11y-hidden으로 텍스트를 넣어주신 것도 엄청 잘해주셨네요 👍👍👍