-
Notifications
You must be signed in to change notification settings - Fork 1
구현 과제 - 로그인/회원가입 모달 - 예슬 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="ko"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>로그인 또는 회원가입</title> | ||
| <link rel="stylesheet" href="./style.css"> | ||
| </head> | ||
|
|
||
| <body> | ||
| <h1 class="a11y-hidden">로그인 페이지</h1> | ||
| <article class="box"> | ||
|
|
||
| <header> | ||
| <h2>로그인 또는 회원가입</h2> | ||
| <button type="button" class="btn-close"><img src="./images/close.png" alt="닫기"></button> | ||
| </header> | ||
| <main> | ||
| <section class="section1"> | ||
| <h3>위니브에서 여러분의 궁금증을 해결하세요! :)</h3> | ||
| <form class="form"> | ||
| <div class="login"> | ||
| <label for="user-id" class="a11y-hidden">아이디</label> | ||
| <input id="user-id" type="text" placeholder="아이디"> | ||
| </div> | ||
| <div class="login"> | ||
| <label for="user-pw" class="a11y-hidden">비밀번호</label> | ||
| <input id="user-pw" type="password" placeholder="비밀번호"> | ||
| </div> | ||
| <div class="hold"> | ||
| <input class="loghold txt-hide" id="inpHold" type="checkbox"> | ||
| <label class="label-hold" for="inpHold">로그인 상태 유지</label> | ||
| </div> | ||
| <button type="button" class="btn-login">로그인</button> | ||
| </form> | ||
| <strong class="join">회원가입<span class="bar">|</span> 아이디/비밀번호 찾기</strong> | ||
|
|
||
| </section> | ||
| <section class="section2"> | ||
| <h2 class="a11y-hidden">다른 계정으로 로그인</h2> | ||
| <strong class="or">또는</strong> | ||
| <div class="account"> | ||
| <button type="button" class="icon-google" href="#"> | ||
| <img class="imgcon" src="./images/icon_google.png" alt=""> | ||
| <p>구글 계정으로 로그인</p> | ||
| <button type="button" class="icon-face" href="#"> | ||
| <img class="imgcon" src="./images/icon_facebook.png" alt=""> | ||
| <p>페이스북 계정으로 로그인</p> | ||
| </button> | ||
| <button type="button" class="icon-naver" href="#"> | ||
| <img class="imgcon" src="./images/icon_naver.png" alt=""> | ||
| <p>네이버 계정으로 로그인</p> | ||
| </button> | ||
| <button type="button" class="icon-kakao" href="#"> | ||
| <img class="imgcon" src="./images/icon_kakao.png" alt=""> | ||
| <p>카카오 계정으로 로그인</p> | ||
| </button> | ||
| </div> | ||
| </section> | ||
| </main> | ||
| </article> | ||
|
|
||
| </body> | ||
|
|
||
| </html> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,261 @@ | ||
| @font-face { | ||
| font-family: 'SpoqaHanSansNeo-Regular'; | ||
| src: url('https://cdn.jsdelivr.net/gh/projectnoonnu/noonfonts_2108@1.1/SpoqaHanSansNeo-Regular.woff') format('woff'); | ||
| font-weight: normal; | ||
| font-style: normal; | ||
| } | ||
|
|
||
| h1, | ||
| h2, | ||
| h3, | ||
| p, | ||
| input, | ||
| button, | ||
| ul, | ||
| a { | ||
| margin: 0; | ||
| padding: 0; | ||
| font: inherit; | ||
| } | ||
|
|
||
| ul, | ||
| li { | ||
| list-style: none; | ||
| } | ||
|
|
||
| button:enabled { | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| button { | ||
| background: none; | ||
| border: 0; | ||
| } | ||
|
|
||
| a { | ||
| text-decoration: none; | ||
| color: inherit; | ||
| } | ||
|
|
||
| strong { | ||
| font: inherit; | ||
| } | ||
|
|
||
| img { | ||
| vertical-align: top; | ||
| } | ||
|
|
||
| .a11y-hidden { | ||
| clip: rect(1px, 1px, 1px, 1px); | ||
| clip-path: inset(50%); | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| overflow: hidden; | ||
| padding: 0; | ||
| position: absolute; | ||
| } | ||
|
|
||
| body { | ||
| background-color: #F2F2F2; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| .box { | ||
| display: flex; | ||
| flex-direction: column; | ||
| width: 520px; | ||
| margin: auto; | ||
| background-color: #FFFFFF; | ||
| border-radius: 10px; | ||
| justify-content: center; | ||
|
|
||
| } | ||
|
Comment on lines
+65
to
+74
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. border를 추가하시는 걸 추천드려요!
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 예진님 자세한 리뷰 너무 감사해요ㅜㅜ 정말 많은 도움이 되고 공부가 된거같아요! 꼭 수정하겠습니다! 감사해요!! |
||
|
|
||
| header { | ||
| position: relative; | ||
| border-bottom: 1px solid #C4C4C4; | ||
| } | ||
|
|
||
| header h2 { | ||
|
|
||
| font-size: 16px; | ||
| padding-top: 20px; | ||
| padding-bottom: 18px; | ||
| text-align: center; | ||
|
|
||
| } | ||
|
|
||
| .btn-close { | ||
| position: absolute; | ||
| right: 24px; | ||
| top: 50%; | ||
| transform: translate(50%, -50%); | ||
| } | ||
|
|
||
| .section1 h3 { | ||
| font-family: 'SpoqaHanSansNeo-Regular'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 전체 페이지의 글씨체가 동일하기 때문에, body 태그에 font-family를 주셔도 좋을 것 같아요!
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 너무 감사해요! 수정하겠습니다! |
||
| font-size: 20px; | ||
| font-weight: 500; | ||
| line-height: 24px; | ||
| margin-left: 24px; | ||
| margin-top: 26px; | ||
| margin-bottom: 24px; | ||
|
Comment on lines
+102
to
+104
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. margin: 26px 0 24px 24px; |
||
| } | ||
|
|
||
| .form { | ||
| width: 472px; | ||
| margin: 0 24px; | ||
|
|
||
| } | ||
|
Comment on lines
+107
to
+111
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 추후 반응형을 위해서 width를 px로 고정 시키는 것은 지양하는 것이 좋다고 합니다! |
||
|
|
||
|
|
||
| .form .login input { | ||
| box-sizing: border-box; | ||
| width: 100%; | ||
| height: 50px; | ||
| padding: 15px 16px; | ||
| margin-bottom: 10px; | ||
| border-radius: 5px; | ||
| border: 1px solid #C4C4C4; | ||
| background: #FFF; | ||
| } | ||
|
|
||
| .form .hold { | ||
| margin-top: 7px; | ||
|
|
||
| font-size: 16px; | ||
| color: #767676; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| .txt-hide { | ||
| overflow: hidden; | ||
| width: 1px; | ||
| height: 1px; | ||
| clip-path: inset(50%); | ||
| } | ||
|
|
||
| .label-hold { | ||
| position: relative; | ||
| } | ||
|
|
||
| .label-hold::before { | ||
| display: inline-block; | ||
| content: ''; | ||
| vertical-align: -5px; | ||
| width: 22px; | ||
| height: 22px; | ||
| margin-right: 8px; | ||
| background: url(./images/check-box.svg) | ||
| } | ||
|
|
||
| .btn-login { | ||
| width: 100%; | ||
| height: 50px; | ||
| margin: 20px auto; | ||
| border-radius: 5px; | ||
| background: #2F80ED; | ||
|
Comment on lines
+156
to
+161
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. color, font-size , font-weight 피그마와 비교해보기 |
||
| } | ||
|
|
||
| .join { | ||
| color: #767676; | ||
| font-size: 14px; | ||
| font-weight: 400; | ||
| text-align: center; | ||
| margin-left: 158px; | ||
|
|
||
| } | ||
|
|
||
| .bar { | ||
| margin: 12px; | ||
| } | ||
|
|
||
| .section2 { | ||
| margin-top: 30px; | ||
| } | ||
|
|
||
| .or { | ||
| color: #767676; | ||
| font-size: 14px; | ||
| font-weight: 400; | ||
| text-align: center; | ||
| display: block; | ||
| margin: 0 24px; | ||
| position: relative; | ||
| } | ||
|
|
||
| .or::before, | ||
| .or::after { | ||
| content: ''; | ||
| height: 1px; | ||
| width: 210px; | ||
| background-color: #C4C4C4; | ||
| display: block; | ||
| position: absolute; | ||
| vertical-align: middle; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. display로 인해 속성이 무시됩니다. 'display: block'에서 vertical-align을 사용할 수 없습니다. |
||
| } | ||
|
|
||
| .or::before { | ||
| top: 50%; | ||
| } | ||
|
|
||
| .or::after { | ||
| top: 50%; | ||
| right: 0; | ||
| } | ||
|
|
||
| .account { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 10px; | ||
| margin: 28px 24px 25px 24px; | ||
|
|
||
| } | ||
|
|
||
| [class^="icon"] { | ||
| display: flex; | ||
|
|
||
| color: #767676; | ||
| text-align: center; | ||
| border-radius: 5px; | ||
| height: 50px; | ||
| width: 100%; | ||
| box-sizing: border-box; | ||
| align-items: center; | ||
| position: relative; | ||
| } | ||
|
|
||
| .imgcon { | ||
| width: auto; | ||
| height: auto; | ||
| position: absolute; | ||
| left: 12px; | ||
| } | ||
|
|
||
| [class^="icon"] p { | ||
| margin: 0 auto; | ||
| } | ||
|
Comment on lines
+239
to
+241
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [class^="icon"] 에서 이미 flex를 사용하고 있기 때문에 justify-content: center; 를 주는 방법도 좋을꺼 같습니다! |
||
|
|
||
| .icon-google { | ||
| border: 1px solid #767676; | ||
|
|
||
| } | ||
|
|
||
| .icon-face { | ||
|
|
||
| border: 1px solid #2D9CDB; | ||
| } | ||
|
|
||
| .icon-naver { | ||
| border: 1px solid #00BF18; | ||
|
|
||
|
|
||
| } | ||
|
|
||
| .icon-kakao { | ||
| border: 1px solid #F2C94C; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
회원가입, 아이디/비밀번호 찾기 부분은 a나 button 태그를 이용해서 cursor: pointer; 로 표현해 보시면 더 좋을 것 같아요! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 짱 좋아요. 👍😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 감사드려요! 수정하겠습니다👍😆