Open
Conversation
merrybmc
reviewed
Aug 7, 2023
Collaborator
merrybmc
left a comment
merrybmc
left a comment
There was a problem hiding this comment.
안녕하세요 희준님. 첫 pr을 축하드려요 🎉🎉🎉
구현사항에 대해서 눈에 띄는 부분에 대한 피드백과
svg를 통해 체크박스를 구현하는 방법을 상세하게 서술해드렸어요.
파이팅 💪👍👍
양희준_loginpage/css/style.css
Outdated
Comment on lines
232
to
259
Collaborator
There was a problem hiding this comment.
url 경로가 잘못되어 이미지가 표시되고 있지 않습니다.
url('../images/.svg') 따옴표와 .과 ..을 활용하여 상대경로로 경로 작성이 필요합니다.
양희준_loginpage/index.html
Outdated
Comment on lines
20
to
29
Collaborator
There was a problem hiding this comment.
input과 button 태그는 웹접근성을 고려한 시맨틱 태그와
나중에 js를 구현할 때 필요한 submit 기능을 고려할 때 form 태그로 묶어주시는 것이 좋습니다.
참고해보시면 좋아요. https://developer.mozilla.org/ko/docs/Web/HTML/Element/form
Author
|
병민님 피드백 적용했습니다. 근데 svg 버튼 적용한 부분에서 체크 이미지를 눌렀을때도 체크표시가 변경될 수 있는지 피드백 부탁드립니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기능 구현 완료했습니다.
체크박스 svg파일로 넣었는데 눌렀을때 색 변하도록 구현 가능하신분 리뷰 부탁드립니다!