Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added login_yebinPark/img/Google__G__Logo 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions login_yebinPark/img/check-box.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added login_yebinPark/img/checkmark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added login_yebinPark/img/facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added login_yebinPark/img/message-circle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added login_yebinPark/img/naver-logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
106 changes: 106 additions & 0 deletions login_yebinPark/login.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
@font-face {
font-family: 'SpoqaHanSansNeo-Regular';
src: url('https://cdn.jsdelivr.net/gh/projectnoonnu/noonfonts_2108@1.1/SpoqaHanSansNeo-Regular.woff') format('woff');
font-weight: normal;
font-style: normal;
}

body {
width: 520px;
height: 720px;
border: 1px solid #C4C4C4;
border-radius: 10px;
margin: auto;
}
section {
padding-left: 24px;
}
section h2 {
font-size: 20px;
font-weight: 500;
line-height: 24px; /* 120% */
font-family: 'SpoqaHanSansNeo-Regular';
margin: 24px 0;
}
header {
border-bottom: 1px solid #C4C4C4;
}
header h3{
font-size: 16px;
font-weight: 500;
text-align: center;
}
.another {
width: 520px;
height: 712px;
}
input {
border: 1px solid #C4C4C4;
border-radius: 5px;
display: block;
width: 90%;
margin: 10px 0;
padding: 16px 15px;
}

.form {
padding: 24px;
}

.login {
color: white;
font-family: 'SpoqaHanSansNeo-Regular';
font-size: 18px;
line-height: 22px;
font-weight: 700;
border: #2F80ED;
border-radius: 5px;
background: #2F80ED;
padding: 14px;
display: block;
width: 90%;
}
Comment on lines +50 to +62
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피그마의 요구사항대로 버튼을 다른 요소들과 위치가 맞게 중앙으로 정렬을 해주면 좋을 것 같습니다.




/* 소셜 로그인 */
a {
display: block;
text-decoration: none;
border-radius: 5px;
font-family: 'SpoqaHanSansNeo-Regular';
font-weight: 500;
color: #767676;
margin: 10px 24px;
background-repeat: no-repeat;
padding: 15px auto;
}
.google {
border: 1px solid #767676;
background-image: url(./img/Google__G__Logo\ 1.png);
background-position: 10px 50%;
}
.facebook {
border: 1px solid #2D9CDB;
background-image: url(./img/facebook.png);
background-position: 10px 50%;
}
.naver {
border: 1px solid #00BF18;
background-image: url(./img/naver-logo.png);
background-position: 10px 50%;
}
.kakao {
border: 1px solid #F2C94C;
background-image: url(./img/message-circle.png);
background-position: 10px 50%;
}
a span {
display: flex;
margin: 15px auto;
justify-content: center;
align-items: center;
}
a img {
margin: 11px 10px;
}
42 changes: 42 additions & 0 deletions login_yebinPark/login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>로그인</title>
<link rel="stylesheet" href="./login.css">
</head>
<body>
<header>
<h3>로그인 또는 회원가입</h3>
Comment on lines +11 to +12
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 또는 회원가입은 시맨틱 태그를 고려하였을 때 h1 태그로 바꾸어 주는 것이 좋을 것 같습니다.

<span class="out"></span>
</header>
<section>
<h2>위니브에서 여러분의 궁금증을 해결하세요! :)</h2>
<input>
<input>
<button class="login_state">로그인 상태 유지</button>
<button class="login">로그인</button>
Comment on lines +17 to +20
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. input과 함께 관련된 button 태그들은 form 태그로 묶어주시는게 웹접근성의 시맨틱 태그나 js의 submit을 구현하는 것을 고려하여 좋습니다.

참고 해보시면 좋아요. :)
https://developer.mozilla.org/ko/docs/Web/HTML/Element/form

  1. 로그인 상태 유지와 체크박스의 경우 input 태그와 label 태그를 활용하여 구현해주시는 것이 좋습니다.

  2. 현재 로그인 버튼의 커서가 pointer로 먹히고 있지 않습니다. css 수정이 필요해 보입니다.

<div class="join">
<a href="">회원가입</a>
<a href="">아이디/비밀번호 찾기</a>
</div>
Comment on lines +21 to +24
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a태그끼리 줄바꿈이 일어나고 있습니다. join 클래스에 flex 속성을 주어 가로 정렬을 해주는게 좋을 것 같습니다.

Comment on lines +21 to +24
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a태그 사이에 | 구분선이 빠져있습니다.
그리고 구분선을 추가하실 때 구분선까지 cursor가 pointer 되지않게 고려하여서 구현하시면 좋습니다.

</section>
<span>또는</span>
<div class="another">
<a href="" class="google">
<span>구글 계정으로 로그인</span>
</a>
<a href="" class="facebook">
<span>페이스북 계정으로 로그인</span>
</a>
<a href="" class="naver">
<span>네이버 계정으로 로그인</span>
</a>
<a href="" class="kakao">
<span>카카오톡 계정으로 로그인</span>
</a>
</div>
</body>
</html>