bgpd: do not accept a host route that matches a local address #17976
Conversation
It's covered by topotest/bgp_l3vpn_to_bgp_direct (with the adjustment). Is that ok? |
|
waiting on freeze |
|
One thing that concerns me is that there is no recovery mechanism in place for when the host interface is removed and all of a sudden we have no route to the host anymore in the bgp rib. |
|
Also, how does it work if running a route-server mode (= transparent)? We should relax this also? |
The same issue exists with bgp_nexthop_self() check. Not sure how much we want to do in the code for auto recovery from such a misconfig, i.e., one address assigned to multiple devices. |
It's the same, isn't? If the RS accepts a host route for its own address, the host route may be advertised with a third-party nexthop. That would not be correct. |
Accepting a host route from a BGP peer for a local address would result in inconsistency between BGP and RIB/FIB. Signed-off-by: Enke Chen <[email protected]>
Adjsut topotest/bgp_l3vpn_to_bgp_direct post the patch that rejects host routes for the local addresses from BGP peers. Signed-off-by: Enke Chen <[email protected]>
enkechen-panw
force-pushed
the
check-hostroute
branch
from
c3c70d9 to
29397c0
Compare
|
ci:rerun |
1 similar comment
|
ci:rerun |
Accepting a host route from a BGP peer for a local address would result in inconsistency between BGP and RIB/FIB.