zebra: reduce memory usage by streams when redistributing routes #18030
Conversation
fdumontet6WIND
force-pushed
the
mem_alloc_stream
branch
2 times, most recently
from
7abd16d to
eaf1718
Compare
There was a problem hiding this comment.
I'm going to repeat some of the things I said in the previous version of this.
- encoding zapi is really something that happens... in the zclient library, and it's not really correct to force a bunch of detailed assumptions into zebra (or any other daemon) code.
- consider a single, authoritative "compute_size" function, that accounts for the fixed parts of the zapi_route struct, and the embedded nexthops.
zebra/zapi_msg.c
Outdated
| @@ -1526,6 +1544,7 @@ static void zread_interface_add(ZAPI_HANDLER_ARGS) | |||
| struct interface *ifp; | |||
|
|
|||
| vrf_id_t vrf_id = zvrf_id(zvrf); | |||
|
|
|||
|
please fix the style errors - you can run that tool yourself, in your own sandbox, and save the CI re-runs... |
required stream size is evaluated as a fix part and variable one. the variable one depend on the number of nexthops. Signed-off-by: Francois Dumontet <[email protected]>
fdumontet6WIND
force-pushed
the
mem_alloc_stream
branch
from
eaf1718 to
5099bd6
Compare
|
Dear Mark, |
|
Look, opening multiple versions of the same PR is really not encouraged. We would prefer you use the original PR because that one has comments on it that now we cannot reference. Now we are in a state where there are comments on both of the PR's that we need to make sure it is addressed and frankly it's not very cool to do that. |
|
this is due to a bad synchronization with my github repos. commit was erazed, and new pulled request was triggered. sorry, this was not my intention. |
required stream size is evaluated as a fix part and variable one. the variable one depend on the number of nexthops.