Skip to content

[Design System] Alert, Confirm, Prompt#102

Open
rlawdgus wants to merge 3 commits intomasterfrom
component/modal
Open

[Design System] Alert, Confirm, Prompt#102
rlawdgus wants to merge 3 commits intomasterfrom
component/modal

Conversation

@rlawdgus
Copy link
Copy Markdown
Contributor

@rlawdgus rlawdgus commented Feb 3, 2023

κ°œμš” πŸ”

  • Alert, Confirm, Prompt μ»΄ν¬λ„ŒνŠΈ 개발 PRμž…λ‹ˆλ‹€.

μž‘μ—… λ‚΄μš© πŸ“

  • λ””μžμΈμ„ μž…νžŒ μ•Œλ¦Όμ°½ μ»΄ν¬λ„ŒνŠΈλ₯Ό μ‚¬μš©ν•  수 있게 개발 μ€‘μž…λ‹ˆλ‹€.
  • μ»΄ν¬λ„ŒνŠΈ, μ»¨ν…μŠ€νŠΈ 두 κ°€μ§€ ν˜•νƒœλ‘œ μ œκ³΅ν•  κ³„νšμž…λ‹ˆλ‹€.

기타 사항 πŸ™‹β€β™‚οΈ

  • 23.02.03 κΈ°μ€€ μ™„μ„± ν›„ PR이 μ•„λ‹ˆκ³  μ»¨ν…μŠ€νŠΈ ν˜•νƒœμΈ μ•Œλ¦Όμ°½μ˜ μ‚¬μš©μ„± 및 μ•ˆμ •μ„± 등을 κ²€ν† ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.
  • κ²€ν†  μ „ Alert, AlertProvider만 κ΅¬μ„±ν–ˆκ³  λ‚˜λ¨Έμ§€ μ»΄ν¬λ„ŒνŠΈλ“€κ³Ό 각각 ν…ŒμŠ€νŠΈ 및 storybook은 계속 μž‘μ—…ν•˜κ³  μžˆκ² μŠ΅λ‹ˆλ‹€.
  • 이 μ»΄ν¬λ„ŒνŠΈμ—μ„œ μ‚¬μš©ν•œ λ²„νŠΌ 및 μž…λ ₯창은 ν•΄λ‹Ή μ»΄ν¬λ„ŒνŠΈμ˜ 완성에 따라 μ—…λ°μ΄νŠΈ ν•˜κ² μŠ΅λ‹ˆλ‹€.

@rlawdgus rlawdgus added Developer 개발자 이슈 Process μž‘μ—… λ‹¨μœ„(λ””μžμΈ + 개발) labels Feb 3, 2023
@rlawdgus rlawdgus added this to the Atom Component milestone Feb 3, 2023
@rlawdgus rlawdgus self-assigned this Feb 3, 2023
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 3, 2023

βœ… Deploy Preview for ids-storybook ready!

Name Link
πŸ”¨ Latest commit d42faac
πŸ” Latest deploy log https://app.netlify.com/sites/ids-storybook/deploys/63dcb25253f5db0009d38c75
😎 Deploy Preview https://deploy-preview-102--ids-storybook.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Collaborator

@IRONAGE-Park IRONAGE-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context둜 μ‚¬μš©ν•˜λŠ” λ°©μ‹μ˜ μž₯점이 아직 와닿지 μ•ŠλŠ” 것 κ°™μŠ΅λ‹ˆλ‹€.
일단, μ‚¬μš©μžμ˜ μž…μž₯μ—μ„œ Alert μ»΄ν¬λ„ŒνŠΈλ₯Ό μœ„ν•΄ Providerλ₯Ό μ‚¬μš©ν•΄μ•Ό ν•œλ‹€λŠ” 점과, onConfirm이 μ„ μ–Έλœ 이후 λ°˜λ“œμ‹œ Alertκ°€ λ‹«νžˆκ²Œ λ˜μ–΄ 쀑간 μž‘μ—…μ΄ ν•„μš”ν•  경우(Alertλ₯Ό μ€‘μ²©ν•΄μ„œ λ„μš΄λ‹€κ±°λ‚˜)에 ν™•μž₯성이 λ‹«ν˜€μžˆμ§€ μ•Šμ„κΉŒ 생각이 λ“­λ‹ˆλ‹€.

background: ${({ theme }) => theme.color.primary.blue500};
border: none;
border-radius: 5px;
color: white;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컬러 μ½”λ“œλŠ” λ””μžμΈ μ‹œμŠ€ν…œμœΌλ‘œ ν†΅μΌν•˜λŠ”κ²Œ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.

description: '',
confirmButtonLabel: '확인',
// eslint-disable-next-line @typescript-eslint/no-empty-function
onConfirm: () => {},
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ–΄μ°¨ν”Ό μ˜΅μ…”λ„ 인자라면 λ°˜λ“œμ‹œ 초기 μƒνƒœλ‘œ 넣어쀄 ν•„μš”λŠ” 없을 것 κ°™μŠ΅λ‹ˆλ‹€.

alert.onConfirm();
}

setAlert((prev) => ({ ...prev, open: false }));
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 κ²½μš°μ—, λ§Œμ•½ 이전 μƒνƒœμ—μ„œ description, confirmButtonLabel λ“±μ˜ μ˜΅μ…”λ„ 인자λ₯Ό μ΄ˆκΈ°ν™” ν•΄μ£Όμ§€ μ•ŠμœΌλ©΄, ν•΄λ‹Ή λ‚΄μš©μ„ 이후에 λ³€κ²½ν•΄μ£Όμ§€ μ•Šκ³  μ‚¬μš©ν•  λ•Œ 이전 기둝이 λ‚¨μ•„μžˆμ„ 것 κ°™μŠ΅λ‹ˆλ‹€.

const openAlert = useContext(AlertContext);

return useCallback(
(title: string, description: string, onConfirm?: () => void, confirmButtonLabel?: string) => {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ˜΅μ…”λ„ μΈμžλ“€μ€ μˆœμ„œμ— 영ν–₯을 λ°›μ§€ μ•Šλ„λ‘ 객체둜 λ¬Άμ–΄μ„œ μ‚¬μš©ν•˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.
λ§Œμ•½ onClose λ“±μ˜ ν•¨μˆ˜κ°€ μΆ”κ°€λœλ‹€λ©΄ λͺ¨λ“  μ½”λ“œμ—μ„œ μˆœμ„œλ₯Ό λ³€κ²½ν•΄μ•Ό ν•˜λ―€λ‘œ 어렀움이 λ°œμƒν•  것 κ°™λ„€μš”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer 개발자 이슈 Process μž‘μ—… λ‹¨μœ„(λ””μžμΈ + 개발)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Process] Component - Modal(Prompt) [Process] Component - Modal(Confirm) [Process] Component - Modal(Alert)

2 participants