[Design System] Checkbox Component를 디자인 시스템에 추가한다.#92
Open
IRONAGE-Park wants to merge 30 commits intomasterfrom
Open
[Design System] Checkbox Component를 디자인 시스템에 추가한다.#92IRONAGE-Park wants to merge 30 commits intomasterfrom
IRONAGE-Park wants to merge 30 commits intomasterfrom
Conversation
…하였습니다. 작성 도중 필요 없는 모듈인 `@emotion/babel-plugin`, `@babel/core`, `babel-loader`를 삭제하고, 테스트에서 `svg`를 로드하기 위해 `svg-jest` 모듈을 불러왔습니다.
# Conflicts: # src/App.tsx
- `disabled` 상태와 `locked` 상태 통합하였습니다. - 단일 선택 `Checkbox`에서 `text` `Props`를 반드시 입력해야 하도록 강제하였습니다. - `Toggle`과 `Checkbox`의 `Props`를 통일하였습니다.
# Conflicts: # package.json # src/assets/svg/Check.svg # src/assets/svg/Lock.svg # src/assets/svg/index.ts # yarn.lock
- Set Subtract Icon - Combine to Toggle / Checkbox Props
IRONAGE-Park
requested review from
ckdwns9121,
khGyun,
parkhyunpaper and
rlawdgus
✅ Deploy Preview for ids-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
IRONAGE-Park
changed the title
Collaborator
Author
|
|
Contributor
|
svgJestTransformer |
…AIZ-Design-System into component/checkbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요 🔍
작업 내용 📝
svg-jest모듈이jest28버전 이후로 지원하지 않아 트랜스폼 파일을 작성하였습니다.기타 사항 🙋♂️
RadioButton이 실제HTML의 라디오처럼 동작하게 해야할 지 모르겠습니다.Font가 적용되지 않아 적용하는 코드를 여기에 추가했습니다 ㅠ