Skip to content

[Design System] Input#93

Open
rlawdgus wants to merge 33 commits intomasterfrom
component/input
Open

[Design System] Input#93
rlawdgus wants to merge 33 commits intomasterfrom
component/input

Conversation

@rlawdgus
Copy link
Copy Markdown
Contributor

@rlawdgus rlawdgus commented Oct 2, 2022

개요 🔍

input 컴포넌트 구현

작업 내용 📝

  • box, bar 디자인 별 컴포넌트
  • 내용 초기화 기능
  • 필수 입력인 경우 표시
  • 테스트 코드

기타 사항 🙋‍♂️

  • clearable true를 넘겼을 때 컴포넌트 내부에서 onChange로 클리어가 구현되는 방향으로 작업했는데
  • 기능이 작동은 하나 코드에 빨간 줄이 뜨고 테스트도 통과하지 않습니다.

@rlawdgus rlawdgus added Developer 개발자 이슈 Request 요청 이슈 labels Oct 2, 2022
@rlawdgus rlawdgus self-assigned this Oct 2, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 2, 2022

Deploy Preview for ids-storybook ready!

Name Link
🔨 Latest commit 889ce03
🔍 Latest deploy log https://app.netlify.com/sites/ids-storybook/deploys/638951a5d5127d00092a36ca
😎 Deploy Preview https://deploy-preview-93--ids-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rlawdgus rlawdgus linked an issue Oct 2, 2022 that may be closed by this pull request
@rlawdgus rlawdgus added this to the Atom Component milestone Oct 2, 2022
@rlawdgus rlawdgus added Process 작업 단위(디자인 + 개발) and removed Request 요청 이슈 labels Oct 2, 2022
Copy link
Copy Markdown
Collaborator

@IRONAGE-Park IRONAGE-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고가 많으십니다.

Comment thread src/components/Inputs/Input.style.ts Outdated
Comment thread src/components/Inputs/Input.style.ts Outdated
Comment thread src/components/Inputs/Input.style.ts Outdated
Comment thread src/components/Inputs/Input.style.ts Outdated
Comment thread src/components/Inputs/InputBarFeature.tsx Outdated
Comment thread src/components/Inputs/InputBarFeature.tsx Outdated
Comment thread src/components/Inputs/Input.style.ts
Comment thread src/components/Inputs/InputBar.tsx Outdated
Comment thread src/components/Inputs/__tests__/InputBarFeature.test.tsx Outdated
Comment thread src/components/Inputs/__tests__/InputBar.test.tsx Outdated
@rlawdgus rlawdgus closed this Nov 5, 2022
@rlawdgus rlawdgus reopened this Nov 12, 2022
@rlawdgus
Copy link
Copy Markdown
Contributor Author

rlawdgus commented Nov 12, 2022

  • 나뉘어 있던 파일을(box, box feature, bar, bar feature) 하나로(input) 합쳤습니다.

  • onChange 매개변수를 string타입으로 변경했습니다.

  • clearable: boolean 형태로 구현했습니다.

  • Caution 아이콘의 색을 변경했습니다.

    • 지금 느낌표 부분이 흰색인데 이 디자인도 괜찮은 것 같습니다.
  • 에러 메세지를 추가했습니다.

Comment thread src/components/Inputs/Input.test.tsx Outdated
Comment thread src/components/Inputs/Input.tsx Outdated
Comment thread src/components/Inputs/Input.tsx Outdated
Comment thread src/components/Inputs/Input.tsx Outdated
Comment thread src/components/Inputs/Input.style.ts Outdated
@rlawdgus
Copy link
Copy Markdown
Contributor Author

  • 버튼과 아이콘에서 버튼 하나로 변경했습니다.
  • onChange 이벤트 객체를 받게 변경했습니다.
  • ref를 외부에서 사용할 수 있습니다.
  • 조건을 변수명으로 표현했습니다.
  • 인라인 요소로 수정했습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer 개발자 이슈 Process 작업 단위(디자인 + 개발)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Process] Component - 텍스트 입력 박스 작업 진행

3 participants