Skip to content

Move Enum related features from SerializationFeature to EnumFeature #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 11, 2025

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Apr 10, 2025

fixes #5080

* specified features enabled (compared to settings that this
* mapper instance has).
*/
public ObjectWriter writer(DatatypeFeature f) {
Copy link
Member

@cowtowncoder cowtowncoder Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmh. Why is this added?

EDIT: I see, there is already

public ObjectWriter writer(SerializationFeature feature) {

so it's just following a pattern. All good.

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: just one minor addition to new EnumFeature entries' Javadocs.

@JooHyukKim JooHyukKim requested a review from cowtowncoder April 11, 2025 01:05
@JooHyukKim
Copy link
Member Author

Done!

@cowtowncoder cowtowncoder merged commit ceab973 into FasterXML:3.x Apr 11, 2025
6 checks passed
@JooHyukKim JooHyukKim deleted the fix-5080 branch April 11, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants