-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement things #257
Merged
Merged
Implement things #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ...
substring
/sublist
#255UnusedCodeCheck
andUseDifferentVisibility
for variables #239ConditionalIfCheck
(and maybe others) should not crash with ifs that do not have a then blockif(a);
#235UseFormatString
should not trigger for"^(?!.*[;" + System.lineSeparator() + "]).*$"
#216array.length
with next spoon release #199RegexCheck
should check uses ofString
for known methods that take regex. #217Arrays.fill
should not trigger for mutable classes #245LINE_BREAK
is a non-descriptive name #224STATIC_INTERFACE
problem type and instead emitREDUNDANT_MODIFIER
#222VariablesHaveDescriptiveNames
should ignore vector coordinates likex1
,x2
, ... andy1
,y2
#221Math.floor
lint? #220ArrayIndexOutOfBoundsException
,NullPointerException
, ... that are guaranteed to be used for modifying control-flow #227public
/default
-visibility fields in theUseDifferentVisibility
lint #219|
,&
, ...) #190ImportTypes
should not trigger forHashMap.Entry
#223ConcreteCollectionCheck
crashes with array #226IllegalArgumentException
when callingEnum::valueOf
#192UseFormatString
/UseStringFormatted
#242//TODO
/// TODO
comments #218