[FIX] CI compiles against local cofhe-contracts source#60
Merged
Conversation
Switch @fhenixprotocol/cofhe-contracts dependency from npm 0.0.13 to file:../../ so CI catches compilation errors in FHE.sol before publish. Remove euint256 references from OnChain2.sol (type no longer exists).
Cast bare 0 literals to uint256 in all asEuintX(0) calls to resolve ambiguity with the new bytes32 overloads. Update test contracts to match current FHE.sol API (remove decrypt, fix return types).
Resolve overload ambiguity for asEuintX(0) calls by renaming the bytes32 handle overloads to wrapE* — semantically distinct from plaintext encryption and avoids degrading the trivial encrypt API.
liorbond
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@fhenixprotocol/cofhe-contractsdependency from npm0.0.13tofile:../../so CI compiles the current FHE.sol, not a stale published versioneuint256references fromOnChain2.sol(type no longer exists in current FHE.sol)This PR is expected to fail CI — it exposes the
asEuint8(0)ambiguity bug introduced in #58. A follow-up commit will fix FHE.sol.Test plan
No unique declaration found after argument-dependent lookuperrorasEuint8(0)ambiguity in FHE.sol and confirm CI passes