[codex] Prepare ordvec-manifest for publish dry runs#168
Conversation
There was a problem hiding this comment.
Code Review
This pull request transitions the ordvec-manifest crate from a repo-local, unpublished sidecar to a published crate versioned in lockstep with the core ordvec crate (v0.3.0). This involves updating Cargo.toml configurations, dependency declarations, release documentation, and various READMEs and threat models to reflect its new status. Feedback on the changes points out a broken documentation reference in ordvec-manifest/src/lib.rs pointing to a non-existent function verify_manifest_document.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
cd52ae8 to
c3cae1d
Compare
Review Summary by QodoMake ordvec-manifest publishable and add to CI dry-run validation
WalkthroughsDescription• Make ordvec-manifest publishable with version 0.3.0 and docs.rs metadata • Add ordvec-manifest to CI publish dry-run gate for packaging validation • Update documentation to reflect manifest verifier as lockstep published crate • Add comprehensive library documentation and clarify CLI usage patterns Diagramflowchart LR
A["ordvec-manifest<br/>v0.0.0 unpublished"] -- "version bump<br/>metadata added" --> B["ordvec-manifest<br/>v0.3.0 publishable"]
B -- "CI integration" --> C["publish dry-run<br/>validation"]
D["docs/comments<br/>outdated"] -- "update references" --> E["lockstep crate<br/>terminology"]
File Changes1. ordvec-manifest/Cargo.toml
|
Code Review by Qodo
1.
|
Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
75dc197 to
bbc9d4a
Compare
Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
|
Addressed the remaining docs.rs config finding in 68da3ed. What changed:
Validation:
I also rechecked the Gemini note about |
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 68da3ed |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
|
CI follow-up: the remaining red check is This is not caused by the manifest publishability diff. The same commit has the manifest publish dry-run, release-publish invariants, manifest verifier, and AVX-512 SDE lane green. The release-gate cache hardening for this exact Intel CDN issue is in #165; preferred merge order is #165 first, then rebase/rerun #168 so it inherits the stabilized SDE cache key and timeout/cache behavior. |
Summary
ordvec-manifestpackage-publishable metadata-wise with lockstep0.3.0, docs.rs metadata, and a versionedordvecdependencypublish=false/ checkout-onlyordvec-manifestto the CI publish dry-run gate while leaving the realrelease.ymlcrates.io OIDC expansion for the next laneScout/review loop
release.yml/invariant wiring and manifest package-readiness scout before implementation..github/dependabot.ymland adjusted the manifest README CLI examples to distinguish installed use from pre-release workspace use.Validation
cargo package -p ordvec-manifest --listcargo publish -p ordvec-manifest --dry-run --lockedcargo publish -p ordvec --dry-run --lockedcargo test -p ordvec-manifest --no-default-featurescargo test -p ordvec-manifest --all-featurescargo clippy -p ordvec-manifest --all-targets --all-features -- -D warningsbash tests/release_publish_invariants.shbash tests/release_signed_release_invariants.sh/tmp/ordvec-actionlint/actionlint .github/workflows/ci.yml .github/workflows/release.ymlcargo fmt --all --checkgit diff --checkFollow-up lane
Lane 3B still needs to add the actual
release.ymlcrates.io trusted-publishing path, byte-identity checks, release invariants, and docs forordvec-manifest. This PR intentionally does not publish the manifest crate in the release workflow.