feat: Harden end-to-end encryption with versioned ciphertext and improved error handling - #651
Open
midenotch wants to merge 1 commit into
Open
feat: Harden end-to-end encryption with versioned ciphertext and improved error handling#651midenotch wants to merge 1 commit into
midenotch wants to merge 1 commit into
Conversation
…oved error handling Enhance client-side encryption for private notes and contacts with: - Custom error types (TamperDetectedError, WrongKeyError, InvalidCiphertextError) - User-friendly error messages for tamper detection and wrong passphrase scenarios - Versioned ciphertext format for future algorithm migration - Enhanced encryptedStorage with error callbacks and error tracking - Comprehensive unit tests covering edge cases and error scenarios Security improvements: - AES-GCM encryption with per-record IV (already implemented) - PBKDF2 key derivation with 150,000 iterations (already implemented) - Version byte in ciphertext for algorithm migration - Clear UX messages for decryption failures - Graceful error handling in storage layer Testing: - Added 6 new unit tests for error scenarios - Enhanced encryptedStorage tests with error handling - Versioned ciphertext format verification - Tamper detection and wrong key error tests Resolves FinChippay#640 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance client-side encryption for private notes and contacts with custom error types, user-friendly messages, versioned ciphertext format, and comprehensive error handling. Resolves #640