Fix/swap hardening - #672
Merged
Topmatrixmor2014 merged 13 commits intoAug 19, 2026
Merged
Conversation
🤖 Greptile AI Code ReviewGreptile will automatically review this PR (18 file(s) changed). Review gates:
|
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the in-contract swap path against fee-on-transfer inputs, stale/malformed paths, slippage edge cases, and protocol-fee accounting. Adds a dedicated swap hardening test suite and updates contract/shared error docs.
Type of change
Related issue
Closes #626
Changes
max_amount_inunder rounding and fee-on-transfer top-ups.tests/swap_hardening.rswith 19 tests covering fee-on-transfer, slippage, rounding, stale paths, rollback behavior, fee collector accounting, dust, and large values.ContractErrorcodes in the shared error catalog and regenerate error-code docs.Testing
Local checks run: