Skip to content

Commit

Permalink
清除无用代码
Browse files Browse the repository at this point in the history
  • Loading branch information
Finb committed Sep 26, 2024
1 parent 0bbfcb8 commit 2ff4259
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 37 deletions.
28 changes: 1 addition & 27 deletions View/MessageTableViewCell.swift
Original file line number Diff line number Diff line change
Expand Up @@ -57,32 +57,6 @@ class MessageTableViewCell: BaseTableViewCell<MessageTableViewCellViewModel> {

layoutView()

let tap = UITapGestureRecognizer(target: self, action: #selector(tap))
tap.name = "messageTap"
tap.delegate = self
bodyLabel.addGestureRecognizer(tap)
}

@objc func tap() {
var view = self.superview
while view != nil, (view as? UITableView) == nil {
view = view?.superview
}
guard let tableView = view as? UITableView else {
return
}

guard let indexPath = tableView.indexPath(for: self) else {
return
}
tableView.delegate?.tableView?(tableView, didSelectRowAt: indexPath)
}
// 单击手势如果没点击链接,则传递给UITableView didSelectRow
override func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRequireFailureOf otherGestureRecognizer: UIGestureRecognizer) -> Bool {
if gestureRecognizer.name == "messageTap", otherGestureRecognizer.name == "UITextInteractionNameLinkTap" {
return true
}
return false
}

@available(*, unavailable)
Expand Down Expand Up @@ -153,7 +127,7 @@ class MessageTableViewCell: BaseTableViewCell<MessageTableViewCellViewModel> {
}

self.bodyLabel.attributedText = text
}.disposed(by: rx.disposeBag)
}.disposed(by: rx.reuseBag)
model.date.bind(to: self.dateLabel.rx.text).disposed(by: rx.reuseBag)
}
}
16 changes: 6 additions & 10 deletions View/MessageTableViewCellViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class MessageTableViewCellViewModel: ViewModel {
let url: BehaviorRelay<String>
let date: BehaviorRelay<String>


init(message: Message) {
self.message = message

Expand Down Expand Up @@ -62,13 +61,10 @@ extension MessageTableViewCellViewModel: IdentifiableType {
return "\(self.message.id)"
}

// 移除掉,因会导致下拉刷新时,新的 MessageTableViewCellViewModel 没有绑定到 cell 上
// MessageListViewModel 监听了新的 MessageTableViewCellViewModel 的 urlTap ,但cell绑定的是旧的
// 导致 下拉刷新后, url 点击没反应。
// override func isEqual(_ object: Any?) -> Bool {
// if let obj = object as? MessageTableViewCellViewModel {
// return self.identity == obj.identity
// }
// return super.isEqual(object)
// }
override func isEqual(_ object: Any?) -> Bool {
if let obj = object as? MessageTableViewCellViewModel {
return self.identity == obj.identity
}
return super.isEqual(object)
}
}

0 comments on commit 2ff4259

Please sign in to comment.