-
Notifications
You must be signed in to change notification settings - Fork 15
Update Vertex embedding model & upgrade dependencies #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
update the model from deprecated to current based on :https://cloud.google.com/vertex-ai/generative-ai/docs/embeddings/get-text-embeddings#google-models --> "text-embedding-005"
Summary of ChangesHello @sab-i-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's underlying infrastructure by updating the Vertex text embedding model to its latest version and upgrading various project dependencies. These changes aim to ensure compatibility, leverage improved performance, and align with current best practices for package management and AI model integration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Vertex text embedding model and upgrades several dependencies. The changes are generally good, but I have a couple of points for consideration. I've noticed that the tailwindcss package has been downgraded, which could be unintentional and potentially cause issues. I've left a comment to clarify this. Additionally, in the GraphQL mutation file, the embedding model name is hardcoded in multiple places. I've suggested a way to improve maintainability by using a variable to avoid repetition. Please take a look at my comments.
| "postcss": "^8.4.40", | ||
| "tailwindcss": "^3.4.7", | ||
| "postcss": "^8.5.6", | ||
| "tailwindcss": "^3.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tailwindcss package is being downgraded from version ^3.4.7 to ^3.3.3. This is a significant downgrade and might lead to the loss of recent features and bug fixes. If this downgrade is intentional for compatibility reasons, it would be beneficial to add a comment explaining the necessity. Otherwise, it should be updated to a more recent version.
| data: { | ||
| descriptionEmbedding_embed: { | ||
| model: "textembedding-gecko@003" | ||
| model: "text-embedding-005" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model name text-embedding-005 is hardcoded and repeated 20 times throughout this file. This poses a maintainability challenge, as future updates to the model name would require changes in all 20 locations, increasing the risk of errors.
To improve this, consider using a GraphQL variable for the model name. This would allow you to define it once and reference it where needed.
Example:
mutation updateMovieEmbeddings($modelName: String!) {
movie1: movie_update(
id: "..."
data: {
descriptionEmbedding_embed: {
model: $modelName
text: "..."
}
}
)
// ... and so on
}This way, you only need to update the model name in one place when executing the mutation.
This PR updates the Vertex text embedding model to the current version and upgrades the packages and dependencies to ensure compatibility and improved performance.
Changes
Vertex text embedding model updated to the latest version.
Dependencies/packages updated to their compatible versions.
Minor adjustments in code to accommodate API changes.