Add support for CROSS APPLY and OUTER APPLY generation #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niekschoemaker
force-pushed
the
add-support-for-lateral-joins
branch
from
bb97998 to
b5d272a
Compare
Implement `VisitCrossApply` and `VisitOuterApply` methods to translate CROSS APPLY and OUTER APPLY constructs for Firebird using lateral joins. Adapted logic from Npgsql EF Core provider.
niekschoemaker
force-pushed
the
add-support-for-lateral-joins
branch
from
b5d272a to
d7af605
Compare
|
There's a lot of tests that result in |
- Extension method resolution changed causing the wrong Reverse method to be used, casting it to Enumerable resolves this.
Just making sure, I'm going through all disabled tests at the moment, and if I spot things which are marked as unsupported by efcore, but which are supported now, should those be enabled too? |
Yes. But create separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly copied from the postgres sql provider, that's why I added the copyright notice above it, no need to reinvent the wheel as they already solved it.
Implement
VisitCrossApplyandVisitOuterApplymethods to translate CROSS APPLY and OUTER APPLY constructs for Firebird using lateral joins. Adapted logic from Npgsql EF Core provider.Related to issue #1165