Scaffolding setup now supports Firebird 2.5 #976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
requested changes
Aug 4, 2021
| @@ -192,11 +193,20 @@ ORDER BY | |||
|
|
|||
| private void GetColumns(DbConnection connection, IReadOnlyList<DatabaseTable> tables, Func<string, string, bool> tableFilter) | |||
| { | |||
| var identity_type = "null"; | |||
|
|
|||
| if (connection.State == ConnectionState.Open) | |||
There was a problem hiding this comment.
At this point connection is known to be open.
|
|
||
| if (connection.State == ConnectionState.Open) | ||
| { | ||
| var serverVersion = FbServerProperties.ParseServerVersion(connection.ServerVersion); |
There was a problem hiding this comment.
I would put this into DatabaseModel Create(DbConnection connection, DatabaseModelFactoryOptions options) method and create a property for it.
| if (connection.State == ConnectionState.Open) | ||
| { | ||
| var serverVersion = FbServerProperties.ParseServerVersion(connection.ServerVersion); | ||
| if (serverVersion.Major >= 3) |
There was a problem hiding this comment.
Store MajorVersionNumber directly, to make it easier for future.
|
@SJFriedl Are you going to finish this PR? |
cincuranet
added a commit
that referenced
this pull request
Nov 10, 2021
|
Done via faedc6e. |
|
I have this error when scaffolding a 2.5 Firebird database: Could not find type mapping for column 'XXXXX' with data type 'NUMERIC(4,2)'. Skipping column. |
|
Please report bugs by creating new issues, or if you're asking for help, ask on firebird-net-provider |
|
@mrotteveel He did: #1142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds scaffolding support for versions of Firebird < 3.0 (tested on 2.5) by eliding the
rdb$IDENTITY_TYPEcolumn if the version is too old - it uses the same logic as found in theFbColumns.cssupport elsewhere.This works well enough to create the raft of files representing each table, but it hasn't be tested for anything beyond that as Jiri has said other updates need to be done. So this is only an incremental step.