Skip to content

Conversation

@hvlad
Copy link
Member

@hvlad hvlad commented Dec 15, 2025

No description provided.

…is system-defined and its ODS is greater than ODS of current database.

Thanks to @dyemanov for pointing into this.
@hvlad hvlad requested a review from dyemanov December 15, 2025 14:14
@hvlad hvlad self-assigned this Dec 15, 2025
@hvlad
Copy link
Member Author

hvlad commented Dec 15, 2025

See also comments at #8818

@dyemanov
Copy link
Member

It won't work if a new virtual table is added without raising minor ODS version. This is not the practice we followed so far, but technically it works and it may be used one day. Should we consider this a no-go or relax the checks in this patch?

@hvlad
Copy link
Member Author

hvlad commented Dec 15, 2025

It won't work if a new virtual table is added without raising minor ODS version. This is not the practice we followed so far, but technically it works and it may be used one day. Should we consider this a no-go or relax the checks in this patch?

It is hard to implement check for rule when the rule itself is not defined at all well.
What check do you consider as necessary and enough ?
Should it check for system flag only ? Or it should also check for presence in relations.h ?

@dyemanov
Copy link
Member

I'd check only the system flag (and maybe the virtual table flag). If some persistent system table exists in the metadata cache but missing in the database file, then something is seriously wrong.

@hvlad
Copy link
Member Author

hvlad commented Dec 15, 2025

I'd check only the system flag (and maybe the virtual table flag). If some persistent system table exists in the metadata cache but missing in the database file, then something is seriously wrong.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants