Remove unused imports from defend_parameter.py#100
Merged
fred-huang122 merged 2 commits intofix/goalkeepingfrom Jan 24, 2026
Merged
Remove unused imports from defend_parameter.py#100fred-huang122 merged 2 commits intofix/goalkeepingfrom
fred-huang122 merged 2 commits intofix/goalkeepingfrom
Conversation
Merged
Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on fix/goalkeeping PR
Remove unused imports from defend_parameter.py
Jan 24, 2026
fred-huang122
added a commit
that referenced
this pull request
Jan 24, 2026
* dribbling * improved logic * bug fix * updates * improvements * typing * optimizations to rsim * Update utama_core/rsoccer_simulator/src/ssl/envs/standard_ssl.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * bug fixes + updates * linting * test bug fix * test_fix * undo * undo * reverted params * bug fixes * improved dribbler logic * Update utama_core/team_controller/src/controllers/real/real_robot_controller.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * updates * update fix * updates * updates * fixes * removed prints * feat: change goalkeep * feat: fix bug * add change * Fix: fix the bug run toward enemy * Fix: add a barrier to the forbiden square * Fix: goal keep * simplification of similar codes * simplification * minor: improve in algo * minor: improve in algo * fix: algorithm problem * Fix: write the algorithm that let goalkeeper go between predict line and other robo * Feat: add the third defender * Fix: better tribble defender * chore: linting * Update utama_core/skills/src/goalkeep.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utama_core/skills/src/defend_parameter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utama_core/skills/src/defend_parameter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove unused imports from defend_parameter.py (#100) * Initial plan * Remove unused imports face_ball and move Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Fix goalkeep to handle teams with more than 3 robots (#99) * Initial plan * Fix: handle cases with more than 3 friendly robots in goalkeep Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Remove dead code file goal_keep.py (#98) * Initial plan * Remove dead code file goal_keep.py Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Remove unused math import from standard_ssl.py (#97) * Initial plan * Remove unused math import from standard_ssl.py Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Fix hardcoded goal coordinates in defend_parameter.py for bidirectional play (#96) * Initial plan * Fix hardcoded goal x-coordinates in defend_parameter.py Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> Co-authored-by: Fred Huang <60901360+fred-huang122@users.noreply.github.com> --------- Co-authored-by: Fred Huang <fredhuang122106@gmail.com> Co-authored-by: Fred Huang <60901360+fred-huang122@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Isaac Yong <72080621+isaac0804@users.noreply.github.com> Co-authored-by: Yangping Li <lynfe@LAPTOP-JJF6AK12.localdomain> Co-authored-by: Ningchaun <1311856651@qq.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com>
valentinbruehl
pushed a commit
that referenced
this pull request
Feb 22, 2026
* dribbling * improved logic * bug fix * updates * improvements * typing * optimizations to rsim * Update utama_core/rsoccer_simulator/src/ssl/envs/standard_ssl.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * bug fixes + updates * linting * test bug fix * test_fix * undo * undo * reverted params * bug fixes * improved dribbler logic * Update utama_core/team_controller/src/controllers/real/real_robot_controller.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * updates * update fix * updates * updates * fixes * removed prints * feat: change goalkeep * feat: fix bug * add change * Fix: fix the bug run toward enemy * Fix: add a barrier to the forbiden square * Fix: goal keep * simplification of similar codes * simplification * minor: improve in algo * minor: improve in algo * fix: algorithm problem * Fix: write the algorithm that let goalkeeper go between predict line and other robo * Feat: add the third defender * Fix: better tribble defender * chore: linting * Update utama_core/skills/src/goalkeep.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utama_core/skills/src/defend_parameter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utama_core/skills/src/defend_parameter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove unused imports from defend_parameter.py (#100) * Initial plan * Remove unused imports face_ball and move Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Fix goalkeep to handle teams with more than 3 robots (#99) * Initial plan * Fix: handle cases with more than 3 friendly robots in goalkeep Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Remove dead code file goal_keep.py (#98) * Initial plan * Remove dead code file goal_keep.py Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Remove unused math import from standard_ssl.py (#97) * Initial plan * Remove unused math import from standard_ssl.py Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> * Fix hardcoded goal coordinates in defend_parameter.py for bidirectional play (#96) * Initial plan * Fix hardcoded goal x-coordinates in defend_parameter.py Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com> Co-authored-by: Fred Huang <60901360+fred-huang122@users.noreply.github.com> --------- Co-authored-by: Fred Huang <fredhuang122106@gmail.com> Co-authored-by: Fred Huang <60901360+fred-huang122@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Isaac Yong <72080621+isaac0804@users.noreply.github.com> Co-authored-by: Yangping Li <lynfe@LAPTOP-JJF6AK12.localdomain> Co-authored-by: Ningchaun <1311856651@qq.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: NingchuanIC <212761386+NingchuanIC@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #92 requesting removal of unused imports in
defend_parameter.py.Changes
face_ballandmoveimports fromutama_core.skills.src.utils.move_utilsThe function only uses
go_to_pointfor movement control;face_ballandmovewere never referenced.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.