Skip to content

Conversation

@TabishB
Copy link
Contributor

@TabishB TabishB commented Jan 26, 2026

Summary

  • Fixed incorrect archive path in onboarding template (openspec/archive/openspec/changes/archive/)
  • Fixed double dash in date format (YYYY-MM-DD--YYYY-MM-DD-)

Context

Reported in discussion #583 - a user noticed archives appearing in openspec/archive/ instead of openspec/changes/archive/. Investigation found the onboarding template was documenting the wrong path, which could cause agents following the onboarding to create archives in the wrong location.

Test plan

  • Verify the onboarding template now shows openspec/changes/archive/YYYY-MM-DD-<name>/
  • Run through /opsx:onboard and confirm archive step shows correct path

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Corrected archive storage path and updated user guidance for archived changes.

✏️ Tip: You can customize this high-level summary in your review settings.

The onboarding template incorrectly documented the archive path as
`openspec/archive/YYYY-MM-DD--<name>/` when the actual implementation
uses `openspec/changes/archive/YYYY-MM-DD-<name>/`.

This fixes two issues:
- Missing `changes/` directory in the path
- Double dash `--` instead of single dash `-`

Fixes discussion #583
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Archive paths in skill templates are updated from openspec/archive/YYYY-MM-DD--<name>/ to openspec/changes/archive/YYYY-MM-DD-<name>/, adjusting both the destination folder structure and user-facing guidance text. The naming convention also shifts from double-dash to single-dash formatting.

Changes

Cohort / File(s) Summary
Archive Path Update
src/core/templates/skill-templates.ts
Modified archive destination paths (2 occurrences): changed from openspec/archive/ to openspec/changes/archive/ and adjusted naming format from YYYY-MM-DD--<name> to YYYY-MM-DD-<name>

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 Hop hop, the archive paths now dance anew,
From openspec/archive to changes/ view,
A dash becomes one, the naming refined,
Organization blooms, chaos left behind!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: correcting an archive path in the onboarding template from an incorrect location to the correct one.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vibe-kanban-cloud
Copy link

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

@greptile-apps
Copy link

greptile-apps bot commented Jan 26, 2026

Greptile Overview

Greptile Summary

Fixed two documentation errors in the onboarding template that would have misled AI agents and users about the archive behavior.

Changes:

  • Corrected archive path from openspec/archive/ to openspec/changes/archive/ to match the actual implementation in src/core/archive.ts:20
  • Fixed date format from YYYY-MM-DD--<name> (double dash) to YYYY-MM-DD-<name> (single dash) to match the naming convention in src/core/archive.ts:231

Impact:
The onboarding template documentation now accurately reflects the actual archive command implementation, preventing agents from creating archives in the wrong directory when following the onboarding workflow.

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • The changes are simple documentation-only fixes to a template string that align with the verified implementation. The corrections ensure the onboarding template accurately documents the archive path (openspec/changes/archive/) and date format (YYYY-MM-DD-), both confirmed against the actual implementation in archive.ts
  • No files require special attention

Important Files Changed

Filename Overview
src/core/templates/skill-templates.ts Fixed documentation errors in onboarding template - corrected archive path from openspec/archive/ to openspec/changes/archive/ and fixed double-dash date format to single-dash YYYY-MM-DD-<name>/

Sequence Diagram

sequenceDiagram
    participant User
    participant OnboardingSkill
    participant ArchiveCommand
    participant FileSystem

    User->>OnboardingSkill: Run /opsx:onboard
    OnboardingSkill->>OnboardingSkill: Display Phase 10: Archive
    OnboardingSkill->>User: Show documentation:<br/>"Archives go to openspec/changes/archive/YYYY-MM-DD-<name>/"
    User->>OnboardingSkill: Execute openspec archive "<name>"
    OnboardingSkill->>ArchiveCommand: archive(changeName)
    ArchiveCommand->>ArchiveCommand: getArchiveDate() → YYYY-MM-DD
    ArchiveCommand->>ArchiveCommand: Create archiveName: YYYY-MM-DD-<name>
    ArchiveCommand->>FileSystem: Move openspec/changes/<name>
    FileSystem->>FileSystem: → openspec/changes/archive/YYYY-MM-DD-<name>
    ArchiveCommand->>User: Display "Archived to: openspec/changes/archive/YYYY-MM-DD-<name>/"
    Note over OnboardingSkill,ArchiveCommand: Documentation now matches actual behavior
Loading

@TabishB TabishB merged commit c773ef6 into main Jan 26, 2026
9 checks passed
@TabishB TabishB deleted the fix/onboard-archive-path branch January 26, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants