fix: review feedback on PR #67#1
Merged
Fiuum1 merged 2 commits intoFiuum1:fix-issue-14from Mar 20, 2026
Merged
Conversation
- Fix contest threshold integer division rounding: multiply contestCount by PERCENTAGE_BASE instead of dividing the right-hand side, preventing truncation from silently lowering the effective veto threshold - Change _deduct visibility from private to internal for consistency with other helper functions - Fix gendered language in AlreadyContestedByMember NatSpec - Remove empty src/contracts/modification.txt
RonTuretzky
force-pushed
the
review-fixes
branch
from
40ef36d to
02a5808
Compare
Author
|
@Fiuum1 please merge I don't have acess to merge on your fork After you merge this will update the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_deductvisibility fromprivatetointernalfor consistency with all other helper functionsAlreadyContestedByMemberNatSpec (he→they)src/contracts/modification.txtAddresses review comments on BreadchainCoop#67.
Test plan
forge buildpassesforge test)