Skip to content

Fix Metal GPU #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eloualiche merged 3 commits into from
Dec 15, 2025
Merged

Fix Metal GPU #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f754c4
Fix fill! invokation
gragusa Dec 11, 2025
c7a5000
Merge pull request #1 from gragusa/patch-1
gragusa Dec 11, 2025
3f1b4d8
Update FixedEffectCoefficients.jl
gragusa Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AbstractFixedEffectSolver.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,11 @@ function FixedEffects.solve_coefficients!(r::AbstractVector, feM::AbstractFixedE
if !(feM.weights isa UnitWeights)
feM.b .*= sqrt.(feM.weights)
end
fill!(feM.x, 0.0)
fill!(feM.x, zero(T))
x, ch = lsmr!(feM.x, feM.m, feM.b, feM.v, feM.h, feM.hbar; atol = tol, btol = tol, maxiter = maxiter)
for (x, scale) in zip(feM.x.x, feM.m.scales)
x .*= scale
end
x = Vector{eltype(r)}[collect(x) for x in feM.x.x]
full(normalize!(x, feM.m.fes; tol = tol, maxiter = maxiter), feM.m.fes), div(ch.mvps, 2), ch.isconverged
end
end
8 changes: 4 additions & 4 deletions src/FixedEffectCoefficients.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Define methods used in LSMR
e# Define methods used in LSMR

##############################################################################
##
Expand Down Expand Up @@ -28,14 +28,14 @@ end

function Base.fill!(fecoefs::FixedEffectCoefficients, α::Number)
for x in fecoefs.x
fill!(x, α)
fill!(x, eltype(fecoefs)(α))
end
return fecoefs
end

function LinearAlgebra.rmul!(fecoefs::FixedEffectCoefficients, α::Number)
for x in fecoefs.x
rmul!(x, α)
rmul!(x, eltype(fecoefs)(α))
end
return fecoefs
end
Expand All @@ -52,4 +52,4 @@ function LinearAlgebra.axpy!(α::Number, fecoefs1::FixedEffectCoefficients, feco
axpy!(α, x1, x2)
end
return fecoefs2
end
end