Skip to content

fix(ci): Homebrew cask ships no shell completions - #102

Merged
khvn26 merged 1 commit into
mainfrom
fix/cask-completions
Aug 21, 2026
Merged

fix(ci): Homebrew cask ships no shell completions#102
khvn26 merged 1 commit into
mainfrom
fix/cask-completions

Conversation

@khvn26

@khvn26 khvn26 commented Aug 21, 2026

Copy link
Copy Markdown
Member

brew install Flagsmith/tap/flagsmith installs a working CLI, but every completion script fails to generate:

Failed to generate bash completions from /opt/homebrew/Caskroom/flagsmith/2.0.0/flagsmith:
Failure while executing; `{"SHELL" => "bash"} .../flagsmith completion completion bash`
was terminated by uncaught signal KILL.

In this PR, we fix two failures contributing to the error:

  1. shell_parameter_format: cobra already makes Homebrew pass completion <shell> (Library/Homebrew/utils/shell_completion.rb), so our own args: [completion] produces flagsmith completion completion bash. That prints the help text and generates nothing.
  2. The binary is still quarantined when the completions are generated.

Verification

goreleaser release --snapshot now emits preflight do and a bare generate_completions_from_executable "flagsmith". Installing that cask through a scratch local tap gives a clean install with no warnings and all three files present:

  • /opt/homebrew/share/zsh/site-functions/_flagsmith
  • /opt/homebrew/etc/bash_completion.d/flagsmith
  • /opt/homebrew/share/fish/vendor_completions.d/flagsmith.fish

The quarantine half is directly reproducible:

$ xattr -w com.apple.quarantine "0081;00000000;Safari;" flagsmith && ./flagsmith completion bash
Killed: 9
$ xattr -d com.apple.quarantine flagsmith && ./flagsmith completion bash    # exit 0

Both faults go away for good once we notarise the macOS binaries (#85), at which point the un-quarantine hook can be dropped entirely.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@khvn26, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8dc1ef88-ce3d-49b8-a39d-14b61072469f

📥 Commits

Reviewing files that changed from the base of the PR and between 8efdce3 and a80fcd9.

📒 Files selected for processing (1)
  • .goreleaser.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khvn26
khvn26 merged commit 2d55665 into main Aug 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants