fix(ci): Homebrew cask ships no shell completions - #102
Conversation
|
Warning Review limit reached
Next review available in: 44 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brew install Flagsmith/tap/flagsmithinstalls a working CLI, but every completion script fails to generate:In this PR, we fix two failures contributing to the error:
shell_parameter_format: cobraalready makes Homebrew passcompletion <shell>(Library/Homebrew/utils/shell_completion.rb), so our ownargs: [completion]producesflagsmith completion completion bash. That prints the help text and generates nothing.Verification
goreleaser release --snapshotnow emitspreflight doand a baregenerate_completions_from_executable "flagsmith". Installing that cask through a scratch local tap gives a clean install with no warnings and all three files present:/opt/homebrew/share/zsh/site-functions/_flagsmith/opt/homebrew/etc/bash_completion.d/flagsmith/opt/homebrew/share/fish/vendor_completions.d/flagsmith.fishThe quarantine half is directly reproducible:
Both faults go away for good once we notarise the macOS binaries (#85), at which point the un-quarantine hook can be dropped entirely.