Skip to content

fix: $.-prefixed traits are not prioritised over valid JSONPaths - #266

Merged
khvn26 merged 7 commits into
mainfrom
fix/fall-back-to-trait-lookup-for-non-scalar-jsonpath-valiues
Oct 14, 2025
Merged

fix: $.-prefixed traits are not prioritised over valid JSONPaths#266
khvn26 merged 7 commits into
mainfrom
fix/fall-back-to-trait-lookup-for-non-scalar-jsonpath-valiues

Conversation

@khvn26

@khvn26 khvn26 commented Oct 13, 2025

Copy link
Copy Markdown
Member

No description provided.

@khvn26
khvn26 requested a review from a team as a code owner October 13, 2025 17:33
@khvn26
khvn26 requested review from gagantrivedi and removed request for a team October 13, 2025 17:33
@github-actions

github-actions Bot commented Oct 13, 2025

Copy link
Copy Markdown

File Coverage Missing
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against d2d72ff

@emyller emyller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One possibly critical request.

Comment thread flag_engine/segments/evaluator.py Outdated
Comment thread .gitmodules Outdated
@codspeed-hq

codspeed-hq Bot commented Oct 13, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #266 will not alter performance

Comparing fix/fall-back-to-trait-lookup-for-non-scalar-jsonpath-valiues (d2d72ff) with main (8ea7f68)

Summary

✅ 1 untouched

@khvn26
khvn26 requested a review from emyller October 13, 2025 17:58
@khvn26
khvn26 force-pushed the fix/fall-back-to-trait-lookup-for-non-scalar-jsonpath-valiues branch from a9c6209 to c569710 Compare October 14, 2025 11:34
@khvn26
khvn26 merged commit 789d737 into main Oct 14, 2025
8 checks passed
@khvn26
khvn26 deleted the fix/fall-back-to-trait-lookup-for-non-scalar-jsonpath-valiues branch October 14, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants