fix: delete identity overrides from environments_v2 table on feature delete #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
matthewelwell
changed the title
khvn26
approved these changes
Feb 6, 2025
Co-authored-by: Kim Gustyr <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5080 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 1214 1214
Lines 42277 42308 +31
=======================================
+ Hits 41193 41224 +31
Misses 1084 1084 ☔ View full report in Codecov by Sentry. |
matthewelwell
deleted the
fix/delete-identity-overrides-on-feature-delete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds logic to delete identity override documents from flagsmith_environments_v2 table when a feature is deleted.
How did you test this code?
Added an end-to-end style test to delete a feature from the view.
Note: the test isn't passing and I can't understand why - I can see that the code is being hit in the task, but the item is still in the table when we query it in the test code